Integration tests @tables.bind_row_action() is too picky about buttons layout

Bug #1537526 reported by Timur Sufiev on 2016-01-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Low
Timur Sufiev

Bug Description

First, it cannot bind action to the button with destructive effects (marked with .btn-danger), which is rendered as <button> element instead of <a>. Second, @bind_row_action() decorator doesn't expect to find a single primary action, outside of div.btn-group container - thus failing to click the single button.

Fix proposed to branch: master
Review: https://review.openstack.org/271805

Changed in horizon:
assignee: nobody → Timur Sufiev (tsufiev-x)
status: New → In Progress
Timur Sufiev (tsufiev-x) on 2016-01-28
Changed in horizon:
importance: Undecided → Low

Reviewed: https://review.openstack.org/271805
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=4b83421bf58e4a94c7b449b1f51f4512bfaf81b7
Submitter: Jenkins
Branch: master

commit 4b83421bf58e4a94c7b449b1f51f4512bfaf81b7
Author: Timur Sufiev <email address hidden>
Date: Sun Jan 24 21:12:23 2016 +0300

    Allow @tables.bind_row_action() to bind in 2 additional scenarios

    First, it's now able to bind destructive actions rendered with
    button.btn-dander. Second, now it successfully matches a single
    primary action (button outside of div.btn-group container).

    Change-Id: I1c55dc10b344c4899a80d83f4d18e59d5df266a6
    Closes-Bug: #1537526

Changed in horizon:
status: In Progress → Fix Released

This issue was fixed in the openstack/horizon 9.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers