Jasmine Spec Runner throws console errors

Bug #1532170 reported by Rob Cresswell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Rajat Vig

Bug Description

The following errors are thrown in the console at <dev_server_ip>/jasmine.

jasmine-html.js:105 Spec 'horizon.framework.util.q.extensions booleanAsPromise should reject the promise if condition does not evaluates to true' has no expectations.
jasmine-html.js:105 Spec 'horizon.framework.util.q.extensions booleanAsPromise should resolve the promise only if condition to true' has no expectations.
jasmine-html.js:105 Spec 'Launch Instance Keypair Step LaunchInstanceCreateKeyPairController successful submit calls the successCallback' has no expectations.
jasmine-html.js:105 Spec 'Launch Instance Keypair Step LaunchInstanceImportKeyPairController successful submit calls the successCallback' has no expectations.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/265395

Changed in horizon:
assignee: nobody → Rajat Vig (rajatv)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/265395
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b029b70937a81f2b3404298fa62be0c14546839c
Submitter: Jenkins
Branch: master

commit b029b70937a81f2b3404298fa62be0c14546839c
Author: Rajat Vig <email address hidden>
Date: Fri Jan 8 10:30:38 2016 -0800

    Add expect clause when the test passes

    tests in q.extensions.spec.js are not asserting anything
    when the tests pass. This causes an error when running
    jasmine.

    Change-Id: I0589622944bdeaa69814181a431358b7c307219f
    Partial-Bug: #1532170

Changed in horizon:
importance: Undecided → Medium
Revision history for this message
Akihiro Motoki (amotoki) wrote :

Let's close this once. If we have more issues, feel free to file a new bug.

Changed in horizon:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.