horizon.tables.actions LinkAction referencing a non-existant template

[Itxaka Serrano]

on horizon.tables.actions, class LinkAction, there is a reference to a template that no longer exists:

https://github.com/openstack/horizon/blob/master/horizon/tables/actions.py#L371

[Floren (florenllanos)]

I have my devstack environment without refresh since 26 Nov and I have this file:

floren@vdev:/opt/stack/horizon$ find . -name _data_table_table_action.html
./horizon/templates/horizon/common/_data_table_table_action.html

The code inside the file:

floren@vdev:/opt/stack/horizon/horizon/templates/horizon/common$ more _data_table_table_action.html
{% if action.method != "GET" %}
  <button {{ action.attr_string|safe }} name="action" value="{{ action.get_param_name }}" {% if action.help_text %}help_text="{{ action.help_text }}"{% endif %} type="submit">
    {% if action.icon != None %}<span class="fa fa-{{ action.icon }}"></span> {% endif %}
    {% if action.handles_multiple %}{{ action.verbose_name_plural }}{% else %}{{ action.verbose_name }}{% endif %}
  </button>
{% else %}
  <a href='{{ action.get_link_url }}' title='{{ action.verbose_name }}' {{ action.attr_string|safe }}>
    {% if action.icon != None %}<span class="fa fa-{{ action.icon }}"></span> {% endif %}
    {{ action.verbose_name }}
  </a>
{% endif %}

I tried to find the git log when this change happened (when file was deleted) but I have not been able to find it (sorry I believe that, I do not yet know enough to find in git log).

[Itxaka Serrano (itxaka)]

@Floren, that is great :)

to search for a deleted file in git you can do
git log --all -- <path-to-file>

[Floren (florenllanos)]

Thanks Itxaka!

I found it. Was deleted in commit: 053b5f30d7b2c4b5ba6d885dc28723744e5b22db

[Matt Borland (palecrow)]

FYI I began working on a fix for this at: https://review.openstack.org/#/c/264955/ with duplicate bug: bug/1531982.

I don't have the correct solution as things have changed quite a bit.

[Rob Cresswell (robcresswell-deactivatedaccount)]

There may be more tied in with this. When the table polls after deleting, it seems to return a 404 on the polling, not sure if intended.