No shared attribute error on Network tests

[Lin Hua Cheng]

Error on network tests.

Traceback (most recent call last):
  File "/home/lin-hua-cheng/Documents/workspace/horizon/horizon/tables/base.py", line 1270, in _filter_action
    return action._allowed(request, datum) and row_matched
  File "/home/lin-hua-cheng/Documents/workspace/horizon/horizon/tables/actions.py", line 722, in _allowed
    return super(BatchAction, self)._allowed(request, datum)
  File "/home/lin-hua-cheng/Documents/workspace/horizon/horizon/tables/actions.py", line 136, in _allowed
    return self.allowed(request, datum)
  File "/home/lin-hua-cheng/Documents/workspace/horizon/openstack_dashboard/dashboards/project/networks/tables.py", line 39, in allowed
    if datum and datum.shared:
AttributeError: 'Row' object has no attribute 'shared'

Error caused by this patch: https://review.openstack.org/#/c/246549/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/253508

[Travis Tripp (travis-tripp)]

Wondering why check and gate didn't see this error for this patch during workflow?

[Steve McLellan (sjmc7)]

Yeah, I'm a little surprised - it was an obvious omission looking at Rob's fix probably caused tidying up debug logging but i don't understand how the tests passed without it.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/253508
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d8a60e5e6c864e5919151c7008ced1bdc3c2aad1
Submitter: Jenkins
Branch: master

commit d8a60e5e6c864e5919151c7008ced1bdc3c2aad1
Author: Rob Cresswell <email address hidden>
Date: Fri Dec 4 13:59:40 2015 +0000

    Fix errors showing in Network tests

    A test refactor was a little incomplete, causing errors to be thrown
    during the test run. This patch fixes the test helper causing the
    issues, and corrects the ordering of some of the message arguments.

    Change-Id: I4dc992f1bd1f7b074519987e211a761b6575f8d9
    Closes-Bug: 1522814

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/horizon 9.0.0.0b2 development milestone.