Add Member action in loadbalancers does not enforce protocol as required field

[Mitali Parthasarathy]

In Project->Networks->Load Balancers:

1. Click on Members tab
2. Click on 'Add Member' button

**Make sure there are no instances to be added as members.**

Protocol Port is not a required field but if you don't enter the port, it fails with message "Unable to add members" which does not indicate the actual error.

Horizon log shows this error:
2015-11-30 21:09:39,964 DEBUG 25947 [neutronclient.client]: RESP:400 {'date': 'Mon, 30 Nov 2015 21:09:39 GMT', 'connection': 'keep-alive', 'content-type': 'application/json; charset=UTF-8', 'content-length': '124', 'x-openstack-request-id': 'req-e140a1b7-72dd-46d1-9033-159d1897988a'} {"NeutronError": {"message": "Invalid input for operation: 'None' is not a integer.", "type": "InvalidInput", "detail": ""}}

2015-11-30 21:09:39,964 DEBUG 25947 [neutronclient.v2_0.client]: Error message: {"NeutronError": {"message": "Invalid input for operation: 'None' is not a integer.", "type": "InvalidInput", "detail": ""}}

Neutron Log shows the following error:
2015-11-30 21:09:39,961 DEBUG [neutron.api.v2.base] 597 Request body: {u'member': {u'protocol_port': None, u'pool_id': u'b4996970-2d8f-4d9f-b553-a55bf1a159d0', u'address': u'10.2.2.5', u'admin_state_up': True}}
2015-11-30 21:09:39,962 INFO [neutron.api.v2.resource] 95 create failed (client error): Invalid input for operation: 'None' is not a integer.

Looks like the underlying problem is that protocol_port is removed as a requirement when there are no instances available to be selected as members. However, user can still choose the other way of entering the member ip address and will run into this problem (protocol_port.required will still be set to False as there are no servers).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/252409

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/252409
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5d384cb18da4e274e63938916d941f367b564386
Submitter: Jenkins
Branch: master

commit 5d384cb18da4e274e63938916d941f367b564386
Author: Tatiana Ovchinnikova <email address hidden>
Date: Wed Dec 2 16:50:53 2015 +0300

    Protocol port should be required for LBaaS Add Member

    Protocol port field should be required for LBaaS Add Member action,
    no matter what member source is chosen. This patch set also fixes
    members field's label for the case when there is no available servers.

    Change-Id: Ib0a00a2b7acdbb0d3dd454e54122ec601889a1fc
    Closes-Bug: #1521360

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/horizon 9.0.0.0b2 development milestone.