several launch instance hits cause several requests

[Maurice Escher]

Release: Kilo

I have the 'new' launch instance dialog. After I clicked the launch instance button it takes a while to get the response, during this time it is possible to click the button again and another request will be triggered (resulting in multiple instances being created).

Maybe https://bugs.launchpad.net/horizon/+bug/1461641 would be enough to acknowledge that the request was sent, but I would rather have the button disabled after the first submission to prevent the users from accidental creation of multiple instances.

[Richard Jones (r1chardj0n3s)]

Indeed a user that double-clicks with the correct timing (not hard to do) will create two instances, which is undesirable.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/251205

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/251205
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fec418f830b73f77cc6ae9c73255f0887d296202
Submitter: Jenkins
Branch: master

commit fec418f830b73f77cc6ae9c73255f0887d296202
Author: Richard Jones <email address hidden>
Date: Mon Nov 30 16:53:50 2015 +1100

    Disable angular wizard finish button when clicked

    The finish button may be pressed multiple times before the wizard
    is closed, causing the underlying action to be invoked multiple
    times. This patch disables the button before invoking the action,
    re-enabling it if there is some error completing the action.

    Closes-Bug: 1520598
    Change-Id: If3363f6115af2a949f720eb3833dec405e986308

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/horizon 9.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/287135

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/287135
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d27adc03088c24c1284554fe1c4412f0b61ec4ff
Submitter: Jenkins
Branch: stable/liberty

commit d27adc03088c24c1284554fe1c4412f0b61ec4ff
Author: Richard Jones <email address hidden>
Date: Mon Nov 30 16:53:50 2015 +1100

    Disable angular wizard finish button when clicked

    The finish button may be pressed multiple times before the wizard
    is closed, causing the underlying action to be invoked multiple
    times. This patch disables the button before invoking the action,
    re-enabling it if there is some error completing the action.

    Closes-Bug: 1520598
    Change-Id: If3363f6115af2a949f720eb3833dec405e986308
    (cherry picked from commit fec418f830b73f77cc6ae9c73255f0887d296202)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 8.0.2 release.