Branding: Horizon Header should be more composable

Bug #1518584 reported by Diana Whitten on 2015-11-21
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Low
Diana Whitten

Bug Description

The Horizon _header.html template has many components within it: region pickers, user menus, logos. All of these things are highly desirable to customize, but because it is all contained in the same template, a brander will have to override the entire template. This is not ideal as it increase the cost of maintenance.

Changed in horizon:
assignee: nobody → Diana Whitten (hurgleburgler)

Fix proposed to branch: master
Review: https://review.openstack.org/248394

Changed in horizon:
status: New → In Progress
Changed in horizon:
importance: Undecided → Low

Reviewed: https://review.openstack.org/248394
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=378623217deb434a067fffb1fcf83e3520ffda33
Submitter: Jenkins
Branch: master

commit 378623217deb434a067fffb1fcf83e3520ffda33
Author: Diana Whitten <email address hidden>
Date: Mon Dec 14 14:42:35 2015 -0700

    Branding: Horizon Header should be more composable

    A recent branding effort exposed several aspects of the header
    templates that need to be more composable to enable richer
    customizations.

    The Horizon _header.html template has many components within it:
    region pickers, user menus, logos. All of these things are highly
    desirable to customize, but because it is all contained in the same
    template, a brander will have to override the entire template. This
    is not ideal as it increase the cost of maintenance.

    The splash section of the login page, the context selector, the logo
    section of the header, the user menu and the region selector are now
    composable to a much more granular level. The top navigation menus
    can now be used outside of existing within a list. The templates
    now allow use as normal, standalone dropdown items.

    Also, the current primary color used for 'material' was highly
    unpleasant with OpenStack Red. Another color on the material design
    palette was chosen, very close to the previous blue. See
    https://www.google.com/design/spec/style/color.html#color-color-palette

    To showcase this new composability, 'material' now shows how to
    customize the logo and logo-splash beyond just replacing the png, but
    now allowing the use of any type of image. In this case, the
    OpenStack logos have been upgraded with their svg counterparts.

    It was also noted that the context selection menu was using the wrong
    variable to set the color of its links. This was corrected.

    Closes-Bug: #1518584

    Change-Id: Ib544176b9836e17fc913170664646e1d10eda831

Changed in horizon:
status: In Progress → Fix Released

This issue was fixed in the openstack/horizon 9.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers