Some volume related quotas are not translatable on admin->defaults

Bug #1516684 reported by Doug Fish
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Itxaka Serrano

Bug Description

After preparing my Horizon environment as described in http://docs.openstack.org/developer/horizon/contributing.html#running-the-pseudo-translation-tool I observe several non-translatable quotas:

Per Volume Gigabytes
Volumes Lvmdriver-1
Gigabytes Lvmdriver-1
Snapshots Lvmdriver-1

Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

Doug - where are you seeing this?

Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

Derp, bug title says where.

Changed in horizon:
status: New → Confirmed
Changed in horizon:
importance: Undecided → High
Doug Fish (drfish)
tags: added: low-hanging-fruit
Revision history for this message
Dan Nguyen (daniel-a-nguyen) wrote :

I followed the steps above on my mac but was not able to reproduce.
I can see that the Create Project Modal shows localized strings for Cinder.
Perhaps I'm not looking in the right place?

Revision history for this message
Itxaka Serrano (itxaka) wrote :

its on /admin/defaults/ and indeed, there are several strings not translated.

Itxaka Serrano (itxaka)
Changed in horizon:
assignee: nobody → Itxaka Serrano (itxakaserrano)
status: Confirmed → In Progress
Revision history for this message
Itxaka Serrano (itxaka) wrote :

I have done a patch for dynamic allowing those values to be translated but Im not even sure if we should show them.

They are dynamic values depending on the type of volumes created by the operator.

But, do volume types have quotas? I mean, they have but can they be changed or do they default to -1 and then use the normal volumes quota for checking?

Maybe in that case what we should do is filter them instead and discard them.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/251934

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/251934
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6b06195a3f09a9c30edcf279d8343fcd2e661579
Submitter: Jenkins
Branch: master

commit 6b06195a3f09a9c30edcf279d8343fcd2e661579
Author: Itxaka <email address hidden>
Date: Tue Dec 1 16:55:25 2015 +0100

    Make some volume related quotas translatable

    One static quota (Per volume size (GiB)) and some dynamic quotas
    were not being translated due to their dynamic nature.
    This patch tries to address that.

    Change-Id: I219d36676e21431f434accfdd99dbfb6191519e1
    Closes-Bug: #1516684

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b2

This issue was fixed in the openstack/horizon 9.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.