get_attachment_name() makes a lot of unnecessary calls to Nova

[Timur Sufiev]

Due to some unexpected condition the `else` branch here https://github.com/openstack/horizon/blob/stable/juno/openstack_dashboard/dashboards/project/volumes/volumes/tables.py#L268 is often hit, this causes a lot of requests to Nova made while rendering Admin->Volumes panel (even with all required instances already collected one time).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/241224

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/241224
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/241224
Reason: Due to inactivity and merge conflict

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/241224
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=3a99499ba0adafd1e64262a5ba63ae94b1f05cf0
Submitter: Jenkins
Branch: master

commit 3a99499ba0adafd1e64262a5ba63ae94b1f05cf0
Author: Ivan Kolodyazhny <email address hidden>
Date: Wed May 24 13:00:46 2017 +0300

    Get all needed instances for volumes attachments at Admin->Volumes

    Nova server_list() wrapper needs to receive an explicit `all_tenants`
    boolean flag in order to request instances for _all_ tenants -
    otherwise while rendering Admin->Volumes table Django will request
    missing instances (to get their names for volume attachments) one by
    one, thus significantly increasing response time.

    This patch adds check if all_tenants in search_opts and add it to
    the search else uses tenant_id in the search_opts.

    Co-Authored-By: Dmitry Sutyagin <email address hidden>
    Co-Authored-By: Ivan Kolodyazhny <email address hidden>
    Change-Id: I4761d7da15036b69619649871aef91e1799ee385
    Closes-Bug: #1508568

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 13.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/521066

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/521066
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=016876bee59f1aaa94b459355550e95e4d840905
Submitter: Zuul
Branch: stable/pike

commit 016876bee59f1aaa94b459355550e95e4d840905
Author: Ivan Kolodyazhny <email address hidden>
Date: Wed May 24 13:00:46 2017 +0300

    Get all needed instances for volumes attachments at Admin->Volumes

    Nova server_list() wrapper needs to receive an explicit `all_tenants`
    boolean flag in order to request instances for _all_ tenants -
    otherwise while rendering Admin->Volumes table Django will request
    missing instances (to get their names for volume attachments) one by
    one, thus significantly increasing response time.

    This patch adds check if all_tenants in search_opts and add it to
    the search else uses tenant_id in the search_opts.

    Co-Authored-By: Dmitry Sutyagin <email address hidden>
    Co-Authored-By: Ivan Kolodyazhny <email address hidden>
    Change-Id: I4761d7da15036b69619649871aef91e1799ee385
    Closes-Bug: #1508568
    (cherry picked from commit 3a99499ba0adafd1e64262a5ba63ae94b1f05cf0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 12.0.2 release.