api.nova.Server makes suboptimal calls to Glance

[Timur Sufiev]

Each access to Server.image_name property may result in a call to Glance API (see https://github.com/openstack/horizon/blob/8.0.0/openstack_dashboard/api/nova.py#L118) which is suboptimal and leads to many unnecessary requests when Server() is invoked from server_list() function.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/238189

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/238189
Reason: Abandoning for now, hasn't been updated in 3 months. Feel free to restore and update if you get time to work on the patch. Thanks!

[Akihiro Motoki (amotoki)]

The reported issue can be addressed by a fix for bug 1711486. bug 1711486 was reported later but it describes the situation when an issue reported here happens. A fix is already proposed, so I mark this as a duplicate of bug 1711486.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.openstack.org/238189
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/238189
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=deb55b8411434b32a2ea92f1a825e7dea36deea5
Submitter: Zuul
Branch: master

commit deb55b8411434b32a2ea92f1a825e7dea36deea5
Author: BubaVV <email address hidden>
Date: Tue May 29 18:26:33 2018 +0300

    Call Glance list with certain image ids

    This patch uses glance list filtering, which allow to query images
    for the list of required ids. See [1] for details.

    Patch rebased to master. Added test for proposed Glance API request

    [1] https://developer.openstack.org/api-ref/image/v2/#show-images

    Related-Bug: #1508554
    Co-Authored-By: Ivan Kolodyazhny <email address hidden>
    Co-Authored-By: Vadym Markov <email address hidden>
    Change-Id: Iac485c1b448011fec97ba5bfaa83851914b294d9

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/rocky
Review: https://review.opendev.org/695593

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/695593
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7f218c8e7d0ac78d066e397952ae8c8a9b7df985
Submitter: Zuul
Branch: stable/rocky

commit 7f218c8e7d0ac78d066e397952ae8c8a9b7df985
Author: BubaVV <email address hidden>
Date: Tue May 29 18:26:33 2018 +0300

    Call Glance list with certain image ids

    This patch uses glance list filtering, which allow to query images
    for the list of required ids. See [1] for details.

    Patch rebased to master. Added test for proposed Glance API request

    [1] https://developer.openstack.org/api-ref/image/v2/#show-images

    Related-Bug: #1508554
    Co-Authored-By: Ivan Kolodyazhny <email address hidden>
    Co-Authored-By: Vadym Markov <email address hidden>
    Change-Id: Iac485c1b448011fec97ba5bfaa83851914b294d9
    (cherry picked from commit deb55b8411434b32a2ea92f1a825e7dea36deea5)