Actions "Lock Instance" and "Unlock Instance" should not be shown at the same time

Bug #1505845 reported by Ying Zuo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Ying Zuo

Bug Description

Project -> Compute -> Instances

Create a new instance and you will see both "Lock Instance" and "Unlock Instance" are available. Only one of them should be applicable at the time.

Tags: nova
Ying Zuo (yingzuo)
Changed in horizon:
assignee: nobody → Ying Zuo (yingzuo)
Revision history for this message
Ying Zuo (yingzuo) wrote :

Found the blueprint for adding instance lock/unlock support.
https://blueprints.launchpad.net/horizon/+spec/lock-unlock-server

Looks like it's blocked by some changes in nova. I am checking if there's anything we can do without the changes in nova.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/272841

Changed in horizon:
status: New → In Progress
Revision history for this message
Ying Zuo (yingzuo) wrote :

The lock status was added to nova 2.9. The fix for this issue is to show/hide the actions using that information.
https://github.com/openstack/nova/commit/49a572a043f27623a15af5f1b8e54c3a560b805c

Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

Marked Medium as it doesn't prevent any functionality, but its confusing to the user.

Changed in horizon:
importance: Undecided → Medium
milestone: none → ongoing
tags: added: nova
Changed in horizon:
milestone: ongoing → next
Changed in horizon:
assignee: Ying Zuo (yingzuo) → David Lyle (david-lyle)
Ying Zuo (yingzuo)
Changed in horizon:
assignee: David Lyle (david-lyle) → Ying Zuo (yingzuo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/272841
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=abfaf1298a8a7ddd0159877b6e8f5328a5e95d46
Submitter: Jenkins
Branch: master

commit abfaf1298a8a7ddd0159877b6e8f5328a5e95d46
Author: Ying Zuo <email address hidden>
Date: Tue Jan 26 15:50:09 2016 -0800

    Show instance lock/unlock actions based on the locked status

    The server locked information has been added to nova v2.9.

    This patch set is to show/hide the lock/unlock actions using
    the locked status from nova.

    To get the locked status, the compute version needs to be
    2.9 or above, which can be set on local_settings.py.

    Change-Id: I947c544b32d6056beae97f1c2aa121dd38fb733b
    Closes-bug: #1505845

Changed in horizon:
status: In Progress → Fix Released
Changed in horizon:
milestone: next → newton-2
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 10.0.0.0b2

This issue was fixed in the openstack/horizon 10.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.