Error in admin Network Details page when dhcp_agent_scheduler not enabled

[Janet Yu]

If the Neutron dhcp_agent_scheduler extension is not enabled, when viewing the Network Details page for a network under Admin > System > Networks, an error message is thrown that says "Unable to list dhcp agents hosting network". It should not be an error if there are intentionally no DHCP agents.

[Rob Cresswell (robcresswell-deactivatedaccount)]

Removed assignee due to inactivity.

[Rob Cresswell (robcresswell-deactivatedaccount)]

This should be a fairly trivial fix. The get_agents_data[1] function needs to check that the extension is enabled first[2], and should only print an error message if the extension is enabled, but nothing could be retrieved. If the extension is not enabled, we can fail silently (or probably just hide the agents table entirely)

1. https://github.com/openstack/horizon/blob/b0f3ec3ace531c110f328d208cded302d2617f88/openstack_dashboard/dashboards/admin/networks/views.py#L132

2. "api.neutron.is_extension_supported(self.request, 'dhcp_agent_scheduler')"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/313100

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/313100
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e33cbd6d6cfcdfe893a1d1e4ddf3bef7b8c929c2
Submitter: Jenkins
Branch: master

commit e33cbd6d6cfcdfe893a1d1e4ddf3bef7b8c929c2
Author: Yosef Hoffman <email address hidden>
Date: Mon May 16 10:12:10 2016 -0400

    Don’t error if dhcp_agent_scheduler not enabled

    First check to see if dhcp_agent_scheduler is enabled before attempting
    to list dhcp agents hosting network. If it is not enabled, just return
    an empty list. Also updated tests as necessary.

    Change-Id: I5f14a5c364f8f1f362f788fb005fb773cae7b9f4
    Closes-Bug: #1498277

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.