FWaaS unit tests typo

Bug #1495968 reported by Tatiana Ovchinnikova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Tatiana Ovchinnikova

Bug Description

There is a typo in neutron_data in the second firewall data:

fw2_dict = {...}
TEST.api_firewalls.add(fw1_dict)
...
TEST.firewalls.add(fw1)

So actually fw2_dict is not used in the tests and that's why a case when there are no associated routers is not considered.

Changed in horizon:
assignee: nobody → Tatiana Ovchinnikova (tmazur)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/223592

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/223592
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=dd901cfd84cd95491964e1d2f6a6e2e7a6325045
Submitter: Jenkins
Branch: master

commit dd901cfd84cd95491964e1d2f6a6e2e7a6325045
Author: Tatiana Ovchinnikova <email address hidden>
Date: Tue Sep 15 16:10:58 2015 +0300

    FWaaS tests improving

    There is a typo in neutron_data in the second firewall data,
    which actually skip this data at all. This patch fixes the typo
    and adds corresponding changes to consider this case.

    Closes-Bug: #1495968

    Change-Id: I9c2250c700c67ee6b6d8495b9347144dd304a3d3

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
milestone: none → liberty-rc1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-rc1 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.