Error when adding a new Firewall Rule

[Lin Hua Cheng]

Reported from openstack-dev ML.

When i try to add new firewall rule , horizon broken with "'NoneType' object has no attribute 'id'" Error.
This was fine about 10 hours back. Seems one of the latest commit broken it.

Traceback in horizon:

2015-09-02 16:15:35.337872 return nodelist.render(context)
2015-09-02 16:15:35.337877 File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", line 903, in render
2015-09-02 16:15:35.337893 bit = self.render_node(node, context)
2015-09-02 16:15:35.337899 File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py", line 79, in render_node
2015-09-02 16:15:35.337903 return node.render(context)
2015-09-02 16:15:35.337908 File "/usr/local/lib/python2.7/dist-packages/django/template/debug.py", line 89, in render
2015-09-02 16:15:35.337913 output = self.filter_expression.resolve(context)
2015-09-02 16:15:35.337917 File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", line 647, in resolve
2015-09-02 16:15:35.337922 obj = self.var.resolve(context)
2015-09-02 16:15:35.337927 File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", line 787, in resolve
2015-09-02 16:15:35.337931 value = self._resolve_lookup(context)
2015-09-02 16:15:35.337936 File "/usr/local/lib/python2.7/dist-packages/django/template/base.py", line 825, in _resolve_lookup
2015-09-02 16:15:35.337940 current = getattr(current, bit)
2015-09-02 16:15:35.337945 File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/utils/html.py", line 59, in attr_string
2015-09-02 16:15:35.337950 return flatatt(self.get_final_attrs())
2015-09-02 16:15:35.337954 File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/utils/html.py", line 42, in get_final_attrs
2015-09-02 16:15:35.337959 final_attrs['class'] = self.get_final_css()
2015-09-02 16:15:35.337964 File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/utils/html.py", line 47, in get_final_css
2015-09-02 16:15:35.337981 default = " ".join(self.get_default_classes())
2015-09-02 16:15:35.337986 File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/tables/base.py", line 792, in get_default_classes
2015-09-02 16:15:35.337991 if not self.url:
2015-09-02 16:15:35.337995 File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/tables/base.py", line 756, in url
2015-09-02 16:15:35.338000 url = self.column.get_link_url(self.datum)
2015-09-02 16:15:35.338004 File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/tables/base.py", line 431, in get_link_url
2015-09-02 16:15:35.338009 return self.link(datum)
2015-09-02 16:15:35.338014 File "/opt/stack/horizon/openstack_dashboard/wsgi/../../openstack_dashboard/dashboards/project/firewalls/tables.py", line 261, in get_policy_link
2015-09-02 16:15:35.338019 kwargs={'policy_id': datum.policy.id})
2015-09-02 16:15:35.338023 AttributeError: 'NoneType' object has no attribute 'id'

[Rob Cresswell (robcresswell-deactivatedaccount)]

This appears to be fixed on master by another patch.

[Sean M. Collins (scollins)]

Marking this as fixed committed due to Rob's comment. Lin Hua, can you verify?

[vishwanath jayaraman (vishwanathj)]

WIth the latest devstack install (as of 9/28/2015), I have been able to create a new firewall rule from Horizon without any issues.
If there is a specific set of steps that I need to follow to try to reproduce the issue, please share and I will attempt that.

[Jeremy Stanley (fungi)]

Please don't switch bugs to security without an explanation as to why you've done so. Reviewing the discussion here, it looks like it describes a temporary defect in the master branch during the Liberty development cycle and fixed prior to release. The OpenStack Vulnerability Management Team does not issue security advisories for problems which don't appear in any official release.