Router rules _get_subnet_connectivity cidr check throws exception

[Frode Nordahl]

The check for wether a cidr is affected by a rule in _get_subnet_connectivity are subject to fail and throw exception if any of the values it checks are None.

This currently breaks the Horizon gate/integration tests.

New version of the check proposed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/218763

[OpenStack Infra (hudson-openstack)]

Change abandoned by Frode Nordahl (<email address hidden>) on branch: master
Review: https://review.openstack.org/218763
Reason: Don't fix someone elses code for fixing a gate test problem. New proposal that skips the test will be proposed.

[Frode Nordahl (fnordahl)]

Fix re-proposed to branch: master
Review: https://review.openstack.org/218763

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/218763
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=749aecda4c81f68eb1e4c0c9d10075135eb5ef81
Submitter: Jenkins
Branch: master

commit 749aecda4c81f68eb1e4c0c9d10075135eb5ef81
Author: Frode Nordahl <email address hidden>
Date: Mon Aug 31 10:25:27 2015 +0200

    Fix usage of netaddr '.broadcast'

    netaddr 0.7.16 changed the behavior of IPNetworks with /31 and /32
    prefixes to make their 'broadcast' attribute return None. This patch
    replaces the use of the attribute with a -1 index lookup to get the
    last address instead.

    Revert Ida700555c133e27da2c76357986adfc8193fe89b and re-enables the
    test_routerrule_detail test.

    Change-Id: I0887b0112f97b537e4c1467c47ab78b1f94f238b
    Closes-Bug: 1490403
    Closes-Bug: 1490423