Available items count in ng launch instance does not update when changing source

[Justin Pomeroy]

In the angular Launch Instance wizard, when changing the boot source the count displayed next to the table of available items does not update. For example, by default the boot source is set to Image and the count displayed reflects the number of images. If you change the boot source to Volume the count does not update to reflect the number of volumes available.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/246698

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/246698
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=223fb86f0b8f480d99915a6a849c0ba991551fb5
Submitter: Jenkins
Branch: master

commit 223fb86f0b8f480d99915a6a849c0ba991551fb5
Author: Cindy Lu <email address hidden>
Date: Thu Jan 14 13:43:33 2016 -0800

    Launch Instance Wizard - Avail items count doesn't update

    In the Angular Launch Instance Wizard, when you change the
    the boot source, the Available items count does not update
    correctly. Example: Boot Source is set to Image by default and
    the Available items Count is correct. Change the boot source.
    The count does not update. Also, when you change back to
    Image, the previously allocated item no longer exists.

    Also fix tiny typo.

    Change-Id: I647b31c7a280af4e10040fb27b4436d489fd8163
    Closes-Bug: #1489618

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/horizon 9.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/493070
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=58b14a83bce12cceeeabcc3531f4b2c842591b5f
Submitter: Zuul
Branch: master

commit 58b14a83bce12cceeeabcc3531f4b2c842591b5f
Author: Bence Romsics <email address hidden>
Date: Mon Aug 14 15:30:51 2017 +0200

    transfer-table: Rethink CHANGED message handler

    Part of the fix to bug #1489618 was working only accidentally. The
    implicit update logic of the allocated table (and the allocatedIds dict)
    treated ctrl.available.sourceItems and ctrl.allocated.sourceItems as
    parallel arrays, while they were not parallel in fact.

    This change allows the sender of the CHANGED message to specify all four
    tables and by that spare any implicit logic of updating some of the
    tables. However if a table is not included in the CHANGED message it
    will be left unchanged. The event is also renamed according to the new
    meaning.

    The single sender of the original message from the horizon repo (ie.
    Launch Instance / Source) is updated.

    The original message type and its handler logic is removed without
    deprecation. That theoretically could cause problems for horizon plugins
    outside of the horizon repo. But I find that unlikely because if
    somebody had relied on that logic they would have likely discovered
    already that it was faulty.

    Change-Id: I38972558e1823f9a88702d2ebcb8de5244cfe16a
    Related-Change: I647b31c7a280af4e10040fb27b4436d489fd8163
    Related-Bug: #1489618