IMAGE_CUSTOM_PROPERTY_TITLES is not available for Angular JS

Bug #1487590 reported by Rajat Vig
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Triaged
Medium
Unassigned

Bug Description

The current translations for the image properties come from deep inside python in local_settings.py.

It's also part of documentation.

There's no current angular way of fetching those and displaying them.

The particular setting name is IMAGE_CUSTOM_PROPERTY_TITLES
and is used in openstack_dashboard/dashboards/project/images/images/tabs.py:29

Revision history for this message
Doug Fish (drfish) wrote :

So after clarification from Matt Borland in IRC: the key issue here is that there way for angular code to retrieve the value for IMAGE_CUSTOM_PROPERTY_TITLES. The problem isn't specifically related to it being in local_setings vs settings.

There is some strangeness around these values: they really never get included in the captured in the PO file for them to be translated. However, several of them work because the strings are included elsewhere in the UI.

I'd think as part of this effort, IMAGE_CUSTOM_PROPERTY_TITLES should be defined in settings.py. This would have the added benefits of
1) making it match what is claimed in the documentation (https://github.com/openstack/horizon/blob/d7937c89a0045ac264c784d23e475d72123b07bc/doc/source/topics/settings.rst#L629) The default is actually {} - what we document is the default is what is included in the example files.
2) making it explicitly translatable. Stuff in the local_settings example doesn't get picked up for translations - I don't think it should. However, settings.py does get checked for translatable strings.

Changed in horizon:
status: New → Triaged
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.