Neutron rest test case should not override setupClass() method

Bug #1481143 reported by Lin Hua Cheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Lin Hua Cheng

Bug Description

The setupClass() is overridden, this will cause issue in the future, plus it is overridden without calling super().

https://review.openstack.org/#/c/158867

the broken tests is exposed when it runs in django18

Changed in horizon:
assignee: nobody → Lin Hua Cheng (lin-hua-cheng)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/208781

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/208781
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a354f016abec257891a53277dc936db3fdf65e6c
Submitter: Jenkins
Branch: master

commit a354f016abec257891a53277dc936db3fdf65e6c
Author: lin-hua-cheng <email address hidden>
Date: Mon Aug 3 20:33:59 2015 -0700

    Use setUp() method for neutron rest test

    There is no reason to override the setUpClass() in the test
    case. For data setup, the setUp() should be used.

    There is also an issue where the code is not calling super()
    class, this issue is exposed when running the test in django18.

    Closes-Bug: #1481143
    Partially Implements: blueprint django18

    Change-Id: Ic64cc0a5f0c7d0476bfac63b6e23fe8a1461d6ef

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
importance: Undecided → High
milestone: none → liberty-3
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-3 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.