Missing spec for app.module.js

Bug #1480007 reported by Shaoquan Chen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Shaoquan Chen

Bug Description

We shuld have a spec file for app.module.js.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/207673

Changed in horizon:
assignee: nobody → Shaoquan Chen (sean-chen2)
status: New → In Progress
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

Would normally mark missing tests as high, but there's very little to test here.

Changed in horizon:
importance: Undecided → Medium
milestone: none → liberty-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/207673
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=75e1f4533d503ea9bcff3a52d8c7b31863ad4b0e
Submitter: Jenkins
Branch: master

commit 75e1f4533d503ea9bcff3a52d8c7b31863ad4b0e
Author: Shaoquan Chen <email address hidden>
Date: Thu Jul 30 17:14:42 2015 -0700

    Adding app.module.spec.js

    This patch adds spec for app.module.js which has been missing since
    it cannot be auto-collected to Jasmine test runner.

    Added spec for the module's definition. The run block is all about
    configuring `horizon` object which is in old code and there is patch
    moving them out off app.module.js since they are not really belong
    to here, therefore specs for the code in the run block is not added.

    Change-Id: I835eb6488ee5809ce874dbb7f5d34d06d0b5573d
    Closes-Bug: #1480007

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-3 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.