CSS get None when error in inline_editing

Bug #1479637 reported by Jason Pan
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
eric

Bug Description

Like bugs #1470594

But this time it show up when the inline editor error occur.

GET http://172.22.2.24/static/dashboard/scss/None 404 (NOT FOUND)
jQuery.extend.style @ 6b862e7eeeb9.js:449
(anonymous function) @ 6b862e7eeeb9.js:627
jQuery.extend.access @ 6b862e7eeeb9.js:47
jQuery.each.jQuery.each.jQuery.fn.(anonymous function) @ 6b862e7eeeb9.js:625
self.update.horizon.ajax.queue.error @ c5b1a3ff77e6.js:3180
jQuery.Callbacks.fire @ 6b862e7eeeb9.js:187
jQuery.Callbacks.self.fireWith @ 6b862e7eeeb9.js:192
done @ 6b862e7eeeb9.js:524
jQuery.ajaxTransport.s.send.callback @ 6b862e7eeeb9.js:560

eric (eric-y-i)
Changed in horizon:
assignee: nobody → eric (eric-y-i)
Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/207313
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=af6bddcb2ac27e02e2eb2eacfaeca9e442a8b87b
Submitter: Jenkins
Branch: master

commit af6bddcb2ac27e02e2eb2eacfaeca9e442a8b87b
Author: Eric Yang <email address hidden>
Date: Thu Jul 30 14:16:34 2015 +0800

    CSS get None when error in inline_editing

    I modify status-icon.
    Because the $icons is None.
    But this line 'background-image: url($icons);' will have 404.
    So let it to this line '@if $icons != None { background-image: url($icons); }'.

    Closes-Bug: #1479637

    Change-Id: I47000c80653f051fb27fb6430fe191d9b449ee42

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
importance: Undecided → Low
milestone: none → liberty-3
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-3 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.