Horizon's scss webroot should come from settings.py

Bug #1478794 reported by Diana Whitten
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Diana Whitten

Bug Description

Right now, webroot is being configured by an extra scss variable that is set in the theme. However, this value should come from settings.py

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/206592

Changed in horizon:
assignee: nobody → Diana Whitten (hurgleburgler)
status: New → In Progress
Changed in horizon:
milestone: none → liberty-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/213411

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/206592
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=24f25eddb6f8ec64d624776cfeddc7b01c657820
Submitter: Jenkins
Branch: master

commit 24f25eddb6f8ec64d624776cfeddc7b01c657820
Author: Diana Whitten <email address hidden>
Date: Fri Aug 14 20:51:21 2015 -0700

    SCSS $webroot should inherit from settings.py

    There is double maintenance right now when you change the STATIC_URL
    via settings.py, you must also use a custom theme to have access to
    also change $webroot within the SCSS to serve font-awesome from a
    custom location.

    This patch makes the STATIC_URL available by default in the SCSS
    namespace through variable $static_url.

    Also, it was being called $webroot in the SCSS, but it should
    actually be called $static_url since it should map directly to
    settings.py's STATIC_URL.

    Change-Id: I1ee40652f8110b176f45b8811f0e0197789a73da
    Closes-Bug: #1478794

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-3 → 8.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/213411
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d6b55274984cacefbb98539b593036536ab8c269
Submitter: Jenkins
Branch: master

commit d6b55274984cacefbb98539b593036536ab8c269
Author: Diana Whitten <email address hidden>
Date: Fri Aug 14 20:54:34 2015 -0700

    Webroot Theme is no longer needed

    Because the $static_url scss variable is now available through the
    scss namespace by default via the settings.py value for STATIC_URL,
    it is no longer necessary to have an example theme on how to set
    this manually.

    Change-Id: I39ddfbd8e574768202233cfff09c8699486b3c01
    Closes-Bug: #1478794

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b3

This issue was fixed in the openstack/horizon 9.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.