frequent changes in settings.py causes problems for deployers

[Eric Peterson]

there are lots of changes recently, especially around
fd.populate_horizon_config() calls

deployers find the need to make changes to settings.py and local_settings.py, because of what can be done where.

The churn in settings.py should be minimized, especially around settings that are required for the application to function correctly.

[Tyr Johanson (tyr-6)]

Perhaps openstack_dashboard/static_settings.py is a better spot for the populate_horizon_config calls?

[Richard Jones (r1chardj0n3s)]

That's what was suggested in IRC, and I agree. I'm going to look at breaking out the stuff in settings.py into a function in static_settings.py

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/202889

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/202889
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8c9d9a8fed38b747cb24bd9e0cb4aca7131d846b
Submitter: Jenkins
Branch: master

commit 8c9d9a8fed38b747cb24bd9e0cb4aca7131d846b
Author: Richard Jones <email address hidden>
Date: Fri Jul 17 15:58:34 2015 +1000

    Move static files configuration to reduce settings.py churn

    Operators don't like it when we change settings.py a lot, so this change
    moves application configuration code (which can change a bunch) out of
    settings.py into a separate file.

    Change-Id: If099aa0d5d24827b1ce301f7c586647e6617826d
    Closes-Bug: 1475447