Refactor openstack_dashboard tabs.py code

Bug #1475119 reported by Lawrance
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
In Progress
Wishlist
Unassigned

Bug Description

In most tabs.py table of openstack dashboard apps, we used hardcode for Tab name and slug which we had defined them in related tables Meta, we could use table meta directly. The bug could be a nice low hanging fruit for new contributors.

https://review.openstack.org/#/c/196341/

Changed in horizon:
assignee: nobody → Lawrance (jing)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/196341
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=564d912e697da0679d1ad96d344f59389616d6c2
Submitter: Jenkins
Branch: master

commit 564d912e697da0679d1ad96d344f59389616d6c2
Author: jingliuqing <email address hidden>
Date: Sat Jun 27 13:09:44 2015 +0800

    Refactor the admin tabs code

    Partial-Bug: #1475119
    Change-Id: I3329a09fee2b472ac50bd409e3c5613926d1e39f

Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

A better solution may be just to set the default on the TableTabs.

Changed in horizon:
assignee: Lawrance (jing) → nobody
status: In Progress → Confirmed
importance: Undecided → Wishlist
milestone: none → next
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

Removed assignee due to inactivity.

tags: added: low-hanging-fruit
guoshan (guoshan)
Changed in horizon:
assignee: nobody → guoshan (guoshan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/307533

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/307533
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Akihiro Motoki (amotoki)
Changed in horizon:
assignee: guoshan (guoshan) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.