jasmine tests redirect to login

Bug #1474498 reported by Tyr Johanson
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Dan Siwiec

Bug Description

https://review.openstack.org/#/c/200725 introduced a strange error.

Run Horizon, then visit http://localhost:8000/jasmine/ServicesTests.

It breaks the test runner and redirect to the login page. On my machine this happens in Chrome, but not Safari.

Chrome: 43.0.2357.132
Safari: 8.0.4

Revision history for this message
Shaoquan Chen (sean-chen2) wrote :

Happens on FireFox 39 / Mac OS X10.10.3 as well.

Revision history for this message
Tyr Johanson (tyr-6) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/201802

Changed in horizon:
assignee: nobody → Tyr Johanson (tyr-6)
status: New → In Progress
Changed in horizon:
assignee: Tyr Johanson (tyr-6) → Dan Siwiec (dan-siwiec)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/201802
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f21bccda3b44880b915cfeecd6aa884208f180a5
Submitter: Jenkins
Branch: master

commit f21bccda3b44880b915cfeecd6aa884208f180a5
Author: Tyr Johanson <email address hidden>
Date: Tue Jul 14 16:38:27 2015 -0600

    Fix redirect during jasmine tests

    Change https://review.openstack.org/#/c/200725/ added a new test
    that causes browsers to redirect to the login page while running
    Jasmine tests. This changes the test to inject a mock $window
    object so that the code under test doesn't use the real
    window.location.replace() method.

    Change-Id: Ie55a56b67a6f03dd3fb578e92adb18d8e5fe0b55
    Closes-Bug: #1474498

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
milestone: none → liberty-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-2 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.