Boot instance from volume snapshot fail

[Chung Chih, Hung]

How to reproduce:
1. create new volume and volume source is image
2. Snapshot volume which was created at step1
3. Launch as instance from snapshot volume which was created at step2
Then horizon will display "Block Device Mapping is Invalid: failed to get volume"

Because horizon will send volume source type instead of snapshot source type to nova.
Therefore nova api will try to fetch volume tough volume id instead of snapshot.
Nova create server request's data was incorrect at following link and line.
https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/workflows/create_instance.py#L874

[Michal Dulko (michal-dulko-f)]

Any work is done on this bug? It's actually a broken functionality.

[Chung Chih, Hung (lyanchih)]

Fix proposed to branch: master
Review: https://review.openstack.org/#/c/199457

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/199457
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a1db17aeff842566e6ac429889ca9a3dad9a6daa
Submitter: Jenkins
Branch: master

commit a1db17aeff842566e6ac429889ca9a3dad9a6daa
Author: lyanchih <email address hidden>
Date: Wed Jul 8 17:16:27 2015 +0800

    Couldn't provision instance from volume snapshot

    When user create instance from volume snapshot. Horizon will send
    request to nova and it contain some information about block device
    mapping. But the source type was assigned 'volume'. Therefore nova will
    recognized this instance was boot from volume instead of snapshot, then
    nova couldn't find the id of volume.

    The source type of block device mapping should be determined by whether
    this instance was boot from volume or snapshot.

    Closes-Bug: 1474283

    Change-Id: I38765513833a03f632be11e168efad28aedcf7f0