Horizon header dropdowns are broken with angular-ui bootstrap 0.13

[Paul Karikh]

Horizon has broken header dropdowns (tenant switscher in the left corner and menu with settings and logout button in the right corner) if we use newer version of angular-ui bootstrap library (0.13 or 0.12 instead of 0.11.0.2). Click event has no effect and dropdown list does not drop down.

Looks like the reason of this behaviour is here: https://github.com/openstack/horizon/blob/master/openstack_dashboard/templates/_header.html#L9-L11
Maybe it was happened in this commit: https://github.com/openstack/horizon/commit/7dd2aa8b4a3126145888b45d6f081d8a38454c0f#diff-5ae2ebb96c0fcb671f14ff1d67372c5aR9 when <a> tag was replaced with <button> tag.

[Timur Sufiev (tsufiev-x)]

As soon as Horizon switch to angular-ui/bootstrap 0.13 this is going to be between Critical and High, since you will be able neither to log out, nor change current project. Thus setting to High.

[Timur Sufiev (tsufiev-x)]

Patch under review: https://review.openstack.org/#/c/165893/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/165893
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=59a183aed82552462bb814fc13abb1f0217bca03
Submitter: Jenkins
Branch: master

commit 59a183aed82552462bb814fc13abb1f0217bca03
Author: Paul Karikh <email address hidden>
Date: Thu Mar 19 19:11:07 2015 +0300

    Fix broken header dropdowns

    Dropdowns in header are broken with angular-ui bootstrap v. 0.13.
    This patch makes them work again.

    Change-Id: I35d3087e22e2a29eb7630f73b4f7e6fa71ed2450
    Closes-Bug: #1466146

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/218815

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/218815
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=dab7e45c7456fb5b4e9a9235507dba934b995c1e
Submitter: Jenkins
Branch: master

commit dab7e45c7456fb5b4e9a9235507dba934b995c1e
Author: Timur Sufiev <email address hidden>
Date: Mon Aug 31 14:40:21 2015 +0300

    Fix for the broken header's dropdowns for both v0.11.2 and v0.13

    The dropdownToggle directive from angular-ui/bootstrap v0.11.2
    conflicts with the native Bootstrap data-toggle="dropdown" attribute
    (see https:github.com/angular-ui/bootstrap/issues/2156). This is fixed
    in 0.13, but before that it'd be valuable to ensure that the same html
    markup works the same way with both versions of angular-ui/bootstrap
    (0.11.2 and 0.13). The decorator code could be safely deleted once
    Horizon migrates to angular-ui/bootstrap v0.13.

    Also fix dropdowns in material theme templates.

    Closes-Bug: #1466146
    Change-Id: I8f01c1ce7b0a5dc29bf9d8aba23c9ea7e6e1ec35

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/horizon 9.0.0.0b1 development milestone.