Create Image: Uncaught TypeError: $form.on is not a function

[Tyr Johanson]

on master June 5 2015

Project -> Images -> Create Image dialog

Stacktrace
========
horizon.datatables.disable_actions_on_submit @ horizon.tables.js:185
(anonymous function) @ horizon.modals.js:26
jQuery.extend.each @ jquery.js:657
jQuery.fn.jQuery.each @ jquery.js:266
horizon.modals.initModal @ horizon.modals.js:25
(anonymous function) @ horizon.modals.js:177
jQuery.event.dispatch @ jquery.js:5095
jQuery.event.add.elemData.handle @ jquery.js:4766
jQuery.event.trigger @ jquery.js:5007
jQuery.event.trigger @ jquery-migrate.js:493
(anonymous function) @ jquery.js:5691
jQuery.extend.each @ jquery.js:657
jQuery.fn.jQuery.each @ jquery.js:266
jQuery.fn.extend.trigger @ jquery.js:5690
horizon.modals.success @ horizon.modals.js:48
horizon.modals._request.$.ajax.success @ horizon.modals.js:342
jQuery.Callbacks.fire @ jquery.js:3048
jQuery.Callbacks.self.fireWith @ jquery.js:3160
done @ jquery.js:8235
jQuery.ajaxTransport.send.callback @ jquery.js:8778

[Tyr Johanson (tyr-6)]

Possibly related to a recent change https://review.openstack.org/#/c/187604

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/188984

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/189453

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/188984
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=54ee33c4d844961f7f7f7d94b3c298a015b09e95
Submitter: Jenkins
Branch: master

commit 54ee33c4d844961f7f7f7d94b3c298a015b09e95
Author: Justin Pomeroy <email address hidden>
Date: Fri Jun 5 19:58:18 2015 -0500

    Handle modals properly when disabling table actions

    This fixes a problem when attempting to disable table actions on
    a modal dialog. It causes the Launch Instance modal to render
    incorrectly and other modals result in a
    "$form.on is not a function" error displayed in the browser
    console. This is because the modal init function is assuming the
    argument passed in is a jQuery reference to the modal but in
    reality it is just the modal DOM node itself. The problem is fixed
    by making a jQuery reference to the modal before preparing to
    disable the actions of any tables that might be displayed on it.

    Closes-Bug: #1462544
    Change-Id: I56399468ff5e2b5bcd0b285ece0d6dd001500c24

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/189453
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=bafdabbb1ff3495e141699216d6ffae90e525ab8
Submitter: Jenkins
Branch: stable/kilo

commit bafdabbb1ff3495e141699216d6ffae90e525ab8
Author: Justin Pomeroy <email address hidden>
Date: Tue Jun 2 09:21:42 2015 -0500

    Prevent multiple form submission on table row actions

    This disables any table row actions that do a form submit after an
    action is taken and the form is being submitted. It also changes the
    cursor to make it clear an action is taking place.

    Closes-Bug: #1433849
    Change-Id: I004f0ae43e5201eba30ff38a34be680416407fbc
    (cherry picked from commit ea2f6b35da70d7a9d3f441553dac0f88f6ef9218)

    Handle modals properly when disabling table actions

    This fixes a problem when attempting to disable table actions on
    a modal dialog. It causes the Launch Instance modal to render
    incorrectly and other modals result in a
    "$form.on is not a function" error displayed in the browser
    console. This is because the modal init function is assuming the
    argument passed in is a jQuery reference to the modal but in
    reality it is just the modal DOM node itself. The problem is fixed
    by making a jQuery reference to the modal before preparing to
    disable the actions of any tables that might be displayed on it.

    Closes-Bug: #1462544
    Change-Id: I56399468ff5e2b5bcd0b285ece0d6dd001500c24
    (cherry picked from commit 54ee33c4d844961f7f7f7d94b3c298a015b09e95)