ngReorg broke modals along the way

[Richard Jones]

The horizon modal has been broken along the way during the ngReorg refactoring. The error appears in the Javascript console when the user navigates to almost any page that pops up the modal spinner (switching between Project Overview and Admin Overview, for example).

The error is:

     Uncaught TypeError: Cannot read property 'modal' of undefined
       horizon.modals.modal_spinner @ (some location in compressed js)
       ...

It'll be recommended to turn off compression to figure out what's actually going on.

[Rob Cresswell (robcresswell-deactivatedaccount)]

You can disable compression with the COMPRESS_ENABLED variable in openstack_dashboard/settings.py, for anyone looking.

[Rob Cresswell (robcresswell-deactivatedaccount)]

From Chrome:

Uncaught TypeError: Cannot read property 'modal' of undefinedhorizon.modals.modal_spinner @ horizon.modals.js:58
(anonymous function) @ horizon.accordion_nav.js:80
jQuery.event.dispatch @ jquery.js:5095
jQuery.event.add.elemData.handle @ jquery.js:4766

[Rob Cresswell (robcresswell-deactivatedaccount)]

The issue is here:
https://github.com/openstack/horizon/blob/master/horizon/static/dashboard-app/dashboard-app.module.js

At L30 horizon.conf is set to the dashboard.conf. However, that config doesn't contain the spinner_options; they are only in framework.conf.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/185927

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/185927
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2556b4a9b3709b76017d2e551fe54412681ec599
Submitter: Jenkins
Branch: master

commit 2556b4a9b3709b76017d2e551fe54412681ec599
Author: Rob Cresswell <email address hidden>
Date: Wed May 27 11:46:32 2015 +0100

    Fix modals by making spinner_options accessible

    This patch makes the spinner_options variable accessible to the modal functions
    again.

    Change-Id: I84b6c7e5813d5818b18675e385214feda178c482
    Closes-Bug: 1459115