[sahara] relaunch job fail if job is created by saharaclient and no input args

Bug #1456171 reported by Ken Chen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Ken Chen
Kilo
Fix Released
Undecided
Unassigned

Bug Description

If we launch a job from a job_template without input args by saharaclient directly (not in Horizon), and then relaunch it on Horizon, you will get an error. This is because Horizon thinks job_configs always have elements 'args'. You can refer to horizon/openstack_dashboard/dashboards/project/data_processing/jobs/workflows/launch.py, line 190
job_args = json.dumps(job_configs['args'])

Ken Chen (ken-chen-i)
Changed in horizon:
assignee: nobody → Ken Chen (ken-chen-i)
Ken Chen (ken-chen-i)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/184033

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/184033
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7fe5c80143aad1953d7de4df26b09dc4940f39af
Submitter: Jenkins
Branch: master

commit 7fe5c80143aad1953d7de4df26b09dc4940f39af
Author: Ken Chen <email address hidden>
Date: Mon May 18 19:58:27 2015 +0800

    Add a conditional judgement to avoid invalid dict index

    Before index the job_configs by key 'args', we add a judgement
    to see whether key 'args' exists.

    Closes-Bug: #1456171
    Change-Id: I42fa4bfe5d2b9a90833bae25bd9ac44c614fd9ce

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
milestone: none → liberty-1
importance: Undecided → Low
Changed in horizon:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/201074

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/kilo)

Reviewed: https://review.openstack.org/201074
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=cfb16ecd5a16b214c9751d2e9a773dd9b0d8e69c
Submitter: Jenkins
Branch: stable/kilo

commit cfb16ecd5a16b214c9751d2e9a773dd9b0d8e69c
Author: Ken Chen <email address hidden>
Date: Mon May 18 19:58:27 2015 +0800

    Add a conditional judgement to avoid invalid dict index

    Before index the job_configs by key 'args', we add a judgement
    to see whether key 'args' exists.

    Closes-Bug: #1456171
    Change-Id: I42fa4bfe5d2b9a90833bae25bd9ac44c614fd9ce
    (cherry picked from commit 7fe5c80143aad1953d7de4df26b09dc4940f39af)

tags: added: in-stable-kilo
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-1 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.