[launch instance] new launch instance doesn't honor webroot setting

[Matthias Runge]

I moved my dashboard to /dashboard (webroot setting in local_settings)

With new launch instance: hitting "launch instance", screen stays white,
firebug reports:
"NetworkError: 404 Not Found - http://..../static/angular/wizard/wizard.html"

Note there is "/dashboard" in front of "/static" missing.

[Matthias Runge (mrunge)]

after changing
horizon/static/angular:

basePath constant to:

.constant('basePath', '../../static/angular/');

I'm getting a page with lots(!) of errors "Unable to fetch service catalog"

This is due to get requests are fired up against http://localhost/api/... instead of http://localhost/dashboard/api/...

[Matt Borland (palecrow)]

Looks like we'd need to properly add the basePath injectable also into the horizon/static/horizon/js/angular/services/hz.api.service.js httpCall() method when it actually makes the GET.

[Matt Borland (palecrow)]

s/basePath/webroot/ in previous post...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/181095

[Matt Borland (palecrow)]

Note, openstack_dashboard/static/dashboard/scss/_variables.scss apparently needs individual configuration of a local $webroot variable.

[Matt Borland (palecrow)]

Additional notes: right now the /api services presented don't seem to change as the WEBROOT changes. I imagine this is part of the problem, but am not sure about the appropriate solution--I think they should change with WEBROOT, but what do others think?

[Matthias Runge (mrunge)]

Matt, I think api services need to be accessed via /dashboard/api as well.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/181095
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=35e47358f0e3567b91da1116120c3c9fd97d8e6c
Submitter: Jenkins
Branch: master

commit 35e47358f0e3567b91da1116120c3c9fd97d8e6c
Author: Thai Tran <email address hidden>
Date: Tue Jul 21 10:45:40 2015 -0700

    Fix bug where WEBROOT is not respected

    The WEB_ROOT setting needs to be respected rather than assuming / as
    the root of the application. Simiarly, we can not assume that STATIC_URL
    is a sub url of the WEB_ROOT. They can be configured as two indepedent url.

    Angular templates are loaded dynamically with Ajax, which requires an
    absolute base path. We define those base paths as angular constants for
    template use and future routing.

    TO TEST, follow directions at:
      http://docs.openstack.org/developer/horizon/topics/settings.html#webroot

    Co-Authored-By: Matt Borland <email address hidden>
    Co-Authored-By: Shaoquan Chen <email address hidden>
    Co-Authored-By: Thai Tran <email address hidden>

    Change-Id: Ifcd459633682edc94b270019ce77e17d64bea22d
    Closes-Bug: #1451681

[Paul Karikh (pkarikh)]

Are we going to backport it to Kilo? Is there some conclusion about it?

[Travis Tripp (travis-tripp)]

Paul,

I think it is a good idea to do this for Kilo. We can't directly backport to Kilo, though. It would need to have a patch just for Kilo You could certainly propose a patch for the Kilo branch, but I think we need some advice from David Lyle on the proper process for non-direct (can't just cherry pick) backports.

[Paul Karikh (pkarikh)]

Yes, I agree that we need to backport it, since we have bugs for kilo about it.
For example:
https://bugs.launchpad.net/horizon/+bug/1476439

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/209108
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a903c420e53ece9bf358ee149f449322709741e0
Submitter: Jenkins
Branch: stable/kilo

commit a903c420e53ece9bf358ee149f449322709741e0
Author: Timur Sufiev <email address hidden>
Date: Mon Aug 31 18:46:05 2015 +0300

    Backport the WEBROOT fixes for JS and CSS into Kilo

    This commit includes changes relevant to commits
    https://review.openstack.org/181095 and
    https://review.openstack.org/#/c/201769/. But rather than precisely
    backporting the above commits (which is impossible due to different
    code structure), a 'symptomatic treatment' approach is used: we fix
    every problem which is related to being ignorant to WEBROOT setting in
    Kilo. Among the places being fixed are:

    * edit metadata widget
    * launch instance NG (both templates and service calls).

    Closes-Bug: #1476439
    Related-Bug: #1451681
    Change-Id: I2f5a6189393977c4a4cfccb5f3c771afab21d92c