XStatic-Magic-Search pypi package has errors

Bug #1451567 reported by Drew Fisher
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Unassigned

Bug Description

Two issues:

1: The extracted source directory from the tarball is wrong

$ ls
XStatic-Magic-Search-0.2.0.1.tar.gz

$ tar xzf XStatic-Magic-Search-0.2.0.1.tar.gz

$ ls
xstatic-magic-search/ XStatic-Magic-Search-0.2.0.1.tar.gz

It should be Xstatic-Magic-Search instead of xstatic-magic-search

2: The .git, .gitignore, and .gitreview files/directories are in the tarball and should probably be removed.

$ cd xstatic-magic-search

$ ls -a
./ .gitignore MANIFEST.in* xstatic/
../ .gitreview README.txt* XStatic_Magic_Search.egg-info/
.git/ dist/ setup.py*

Revision history for this message
Kris Lindgren (klindgren) wrote :

It looks like the file that should have been uploaded is under xstatic-magic-search/dists/XStatic-Magic-Search-0.2.0.1.tar.gz

Which does extract out correctly and doesn't have all the git stuff in it:
$ wget https://pypi.python.org/packages/source/X/XStatic-Magic-Search/XStatic-Magic-Search-0.2.0.1.tar.gz#md5=e4ce9925f88f1a901a19563f63b66f95

$ tar -zxvf XStatic-Magic-Search-0.2.0.1.tar.gz
xstatic-magic-search/.git/objects/info/
xstatic-magic-search/.git/refs/
xstatic-magic-search/.git/logs/refs/remotes/origin/HEAD
xstatic-magic-search/.git/objects/50/84c8f6a6fdd76c4ebc8345389b3849972e39e8
xstatic-magic-search/xstatic/
xstatic-magic-search/xstatic/__init__.py
xstatic-magic-search/.git/objects/9d/
xstatic-magic-search/.git/objects/9b/
xstatic-magic-search/.git/objects/9a/
xstatic-magic-search/.git/FETCH_HEAD
xstatic-magic-search/.git/logs/refs/remotes/gerrit/
xstatic-magic-search/dist/XStatic-Magic-Search-0.2.0.1.tar.gz
<snip>

$ cd xstatic-magic-search/dist/

$ls
XStatic-Magic-Search-0.2.0.1.tar.gz

$ tar -zxvf XStatic-Magic-Search-0.2.0.1.tar.gz
XStatic-Magic-Search-0.2.0.1/
XStatic-Magic-Search-0.2.0.1/MANIFEST.in
XStatic-Magic-Search-0.2.0.1/setup.py
XStatic-Magic-Search-0.2.0.1/xstatic/
XStatic-Magic-Search-0.2.0.1/xstatic/pkg/
XStatic-Magic-Search-0.2.0.1/xstatic/pkg/magic_search/
XStatic-Magic-Search-0.2.0.1/xstatic/pkg/magic_search/data/
XStatic-Magic-Search-0.2.0.1/xstatic/pkg/magic_search/data/magic_search.js
XStatic-Magic-Search-0.2.0.1/xstatic/pkg/magic_search/data/magic_search.scss
XStatic-Magic-Search-0.2.0.1/xstatic/pkg/magic_search/data/magic_search.html
XStatic-Magic-Search-0.2.0.1/xstatic/pkg/magic_search/__init__.py
XStatic-Magic-Search-0.2.0.1/xstatic/pkg/__init__.py
XStatic-Magic-Search-0.2.0.1/xstatic/__init__.py
XStatic-Magic-Search-0.2.0.1/XStatic_Magic_Search.egg-info/
XStatic-Magic-Search-0.2.0.1/XStatic_Magic_Search.egg-info/dependency_links.txt
XStatic-Magic-Search-0.2.0.1/XStatic_Magic_Search.egg-info/top_level.txt
XStatic-Magic-Search-0.2.0.1/XStatic_Magic_Search.egg-info/SOURCES.txt
XStatic-Magic-Search-0.2.0.1/XStatic_Magic_Search.egg-info/not-zip-safe
XStatic-Magic-Search-0.2.0.1/XStatic_Magic_Search.egg-info/PKG-INFO
XStatic-Magic-Search-0.2.0.1/XStatic_Magic_Search.egg-info/namespace_packages.txt
XStatic-Magic-Search-0.2.0.1/setup.cfg
XStatic-Magic-Search-0.2.0.1/README.txt
XStatic-Magic-Search-0.2.0.1/PKG-INFO

Changed in horizon:
status: New → Confirmed
importance: Undecided → High
milestone: none → liberty-1
importance: High → Critical
importance: Critical → High
Changed in horizon:
milestone: liberty-1 → liberty-2
Changed in horizon:
milestone: liberty-2 → liberty-3
Revision history for this message
Richard Jones (r1chardj0n3s) wrote :

The XStatic-Magic-Search 0.2.5.1 release on PyPI has the correct structure. It could use some cleanup (it has a XStatic-Magic-Search-0.2.5.1/xstatic/pkg/magic_search/__init__.py~ file) but appears to be correct otherwise. The requirements.txt has been updated to require this release, so this bug should be closed.

Changed in horizon:
status: Confirmed → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-3 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.