New Launch Instance dialog is mostly untranslatable

Bug #1444150 reported by Doug Fish
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Thai Tran

Bug Description

After running
./run_tests.sh --makemessages
./run_tests.sh --pseudo de
./run_tests.sh --compilemessages

then running a dev server, and logging in and using German as the language, the new Launch Instance wizard is mostly untranslatable. On inspection I don't see messages like "Instance Details" or "Please provide the" in
horizon/locale/en/LC_MESSAGES/djangojs.po.

I notice that Cancel/Next/Back are pseudo-translated, but almost nothing else.

Revision history for this message
Doug Fish (drfish) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/174615

Changed in horizon:
assignee: nobody → Thai Tran (tqtran)
status: New → In Progress
Thai Tran (tqtran)
Changed in horizon:
importance: Undecided → High
milestone: none → liberty-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/174615
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=96130205fca340626ef8b091e5e207b0a41ab40d
Submitter: Jenkins
Branch: master

commit 96130205fca340626ef8b091e5e207b0a41ab40d
Author: Thai Tran <email address hidden>
Date: Tue May 5 11:32:33 2015 -0700

    Fixed dashboard angular translation issue

    We now have javascript files in openstack_dashboard as well. However,
    the run_test script does not account for this and only run translation on
    the horizon folder. This patch address this problem. Also removed the
    invalid gettext('') since that causes the msgid to be blank.

    Steps to test:
    1. ./run_tests.sh --makemessages
    2. ./run_tests.sh --pseudo de
    3. ./run_tests.sh --compilemessages
    4. set LAUNCH_INSTANCE_NG_ENABLED = True in local_settings.py
    5. localhost:8001/settings/ and change to deutsch
    6. localhost:port/project/instances/ and click on launch instance

    Co-Authored-By: Doug Fish <email address hidden>
    Change-Id: If1cd1937d40d359a4a4ecd75406f62e8f8802082
    Closes-bug: #1444150

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-1 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.