changing flavor details on running instances will result in errors popping up for users

[Matthias Runge]

1. Install/use and all-in-one w/ demo project
2. As admin, create a flavor and assign to the demo project
3. Log out as admin and log in as demo (must not have admin privs)
4. As demo, launch an instance on this flavor in the demo project
5. Log out as demo and log in as admin
6. As admin, change the amount of RAM for the flavor
7. Log out as admin, log in as demo
8. Check the instances page and size should show "Not available" and there should be an error in the upper right saying "Error: Unable to retrieve instance size information."

The error is only shown for non-admin users.

what happens here:
when editing flavors, nova silently deletes the old flavor, creating a new one. running instances are not touched. the old flavor is marked as deleted, and normal users can not get specifics of that flavor any more.

[Matthias Runge (mrunge)]

it looks like https://bugs.launchpad.net/horizon/+bug/1366166 was not fixed properly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/171537

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/171537
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8c8b130722e3b834fa3f334164c833e0b21f2c82
Submitter: Jenkins
Branch: master

commit 8c8b130722e3b834fa3f334164c833e0b21f2c82
Author: Matthias Runge <email address hidden>
Date: Wed Apr 8 11:35:11 2015 +0200

    Silently drop access to non-existent flavours

    Although not ideal, users are merely confused, when an error
    message pops up, but everything works.

    Change-Id: I765a8ba361e47e5a0af91328865db2515e51606a
    Closes-bug: #1441523

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/172826

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/172826
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2433dbbaa33e38be3ff29dfef1f9dd3f4558f8e5
Submitter: Jenkins
Branch: stable/juno

commit 2433dbbaa33e38be3ff29dfef1f9dd3f4558f8e5
Author: Matthias Runge <email address hidden>
Date: Wed Apr 8 11:35:11 2015 +0200

    Silently drop access to non-existent flavours

    Although not ideal, users are merely confused, when an error
    message pops up, but everything works.

    Change-Id: I765a8ba361e47e5a0af91328865db2515e51606a
    Closes-bug: #1441523
    (cherry picked from commit 8c8b130722e3b834fa3f334164c833e0b21f2c82)