Wrong argument order in Sahara client call

Bug #1439155 reported by Evgeny Sikachev
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Nikita Konovalov

Bug Description

ENVIRONMENT: devstack(01.04.2015)

Sahara node group template is called with wrong argument order.
This makes impossible to set proxy_gateway and volume parameters correctly.

File: openstack_dashboard/api/sahara.py

The client call should be changed to kwargs style, so the order of the arguments does not matter and does not cause errors anymore.

Tags: sahara
Changed in horizon:
assignee: nobody → Nikita Konovalov (nkonovalov)
description: updated
description: updated
summary: - Wrong argument orger in Sahara client call
+ Wrong argument order in Sahara client call
David Lyle (david-lyle)
Changed in horizon:
milestone: none → kilo-rc1
importance: Undecided → High
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/170079

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/170079
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8e6dd6e6f5016c5866dd74c1858959b18e8102dc
Submitter: Jenkins
Branch: master

commit 8e6dd6e6f5016c5866dd74c1858959b18e8102dc
Author: Nikita Konovalov <email address hidden>
Date: Thu Apr 2 13:56:57 2015 +0300

    [Sahara] fix sahara client calls

    The sahara client calls are now using key=value argument passing
    everywhere. This allows the arguments to be listed in any order and not
    cause errors when a new argument is added.

    Change-Id: I3b2304b6c56fb88d280e5b58484bcdb189e04a9d
    Closes-Bug: #1439155

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.