Table widget should show a default message when filtering yields no items

Bug #1438822 reported by Thai Tran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Cindy Lu

Bug Description

Currently angular tables are filterable using the smart-table feature. However, table widget should show a default message when filtering yields no items. This is currently not the case and need to be amend.

Tags: ux ui
Thai Tran (tqtran)
description: updated
Revision history for this message
Sam Betts (sambetts) wrote :

Is there a place where I can see tables without a message, because looking at the identity tables, when there is no results I see "No items to display." appear in the table when I have filter that doesn't match anything, I guess this happening from existing JS outside of the angular work.

Revision history for this message
Lin Hua Cheng (lin-hua-cheng) wrote :

Is this specific to angular tables? Since the Identity angular table didn't land in Kilo, can we defer this to Liberty?

Thai Tran (tqtran)
Changed in horizon:
milestone: kilo-rc1 → liberty-1
Aaron Sahlin (asahlin)
Changed in horizon:
assignee: nobody → Aaron Sahlin (asahlin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/175035

Changed in horizon:
status: New → In Progress
Changed in horizon:
assignee: Aaron Sahlin (asahlin) → Shaoquan Chen (sean-chen2)
Changed in horizon:
milestone: liberty-1 → liberty-2
Changed in horizon:
assignee: Shaoquan Chen (sean-chen2) → Aaron Sahlin (asahlin)
Changed in horizon:
milestone: liberty-2 → liberty-3
Changed in horizon:
assignee: Aaron Sahlin (asahlin) → Cindy Lu (clu-m)
Changed in horizon:
assignee: Cindy Lu (clu-m) → Aaron Sahlin (asahlin)
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-3 → liberty-rc1
Changed in horizon:
assignee: Aaron Sahlin (asahlin) → Cindy Lu (clu-m)
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

Removing from RC1, its not a blocking issue, just a UX improvement.

Changed in horizon:
milestone: liberty-rc1 → none
Changed in horizon:
assignee: Cindy Lu (clu-m) → Rajat Vig (rajatv)
Changed in horizon:
assignee: Rajat Vig (rajatv) → Cindy Lu (clu-m)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/175035
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d37f1a899679fd7efe87ffbbb0bd4d9cb4e0c44f
Submitter: Jenkins
Branch: master

commit d37f1a899679fd7efe87ffbbb0bd4d9cb4e0c44f
Author: Cindy Lu <email address hidden>
Date: Mon Aug 3 15:33:12 2015 -0700

    Add Angular Directive to show msg for empty tables

    Ideally smart-table would have a default message when filtering
    yields no results, but it does not. This patch provides a general
    directive that allows Angular tables to specify a custom message, or
    uses a default "No items to display" message if not.

    To test, set DISABLED = False in
     _3031_identity_users_panel.py, and/or
     _1051_project_ng_images_panel.py and/or
     _2081_admin_flavors_panel.py

    Then go to the last Users panel in the Identity menu,
    last Images Panel in Project menu, respectively.

    Co-Authored-By: Rajat Vig <email address hidden>
    Co-Authored-By: Cindy Lu <email address hidden>

    Change-Id: Ia086bb791d6c74af738209795195ff3ea1860981
    Closes-bug: #1438822

Changed in horizon:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.