Angular table hzSelectAll should select all visible checkboxes in table

Bug #1438351 reported by Kelly Domico
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Kelly Domico

Bug Description

Currently, if the select-all checkbox is clicked, all rows are selected even if it's not visible. For example, when a table is paginated or filtered.

The select-all checkbox should only select all the visible checkboxes in the table.

Changed in horizon:
assignee: nobody → Kelly Domico (kelly-domico)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/169081

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/169081
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=64a87d7ad9ac3b5e234bf6322cf4b787c5a15d2e
Submitter: Jenkins
Branch: master

commit 64a87d7ad9ac3b5e234bf6322cf4b787c5a15d2e
Author: Kelly Domico <email address hidden>
Date: Mon Mar 30 13:47:07 2015 -0700

    Modified hzSelectAll to select all visible checkboxes in table

    The hzSelectAll directive should be used with the 'st-safe-src'
    attribute and should be passed in the displayed collection. When
    used with filtering and pagination, clicking on the select all
    checkbox will only mark the checkboxes of visible rows in the
    table.

    Change-Id: I1e2971f631bf11f5bcff85754b4927212f871f5e
    Closes-Bug: #1438351

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.