[Launch Instance Fix] Establish Baseline Unit Tests

[Matt Borland]

The Angular work done for Launch Instance should have a baseline set of unit tests for each of the steps and the infrastructure supporting them (model, wizard implementation, etc.).

These tests should ensure that each component has basic tests in their associated .spec.js files.

The expectations for such components would be:

Controllers:
 - test for name
 - test injected elements (maybe inherent in other tests)
 - test each exposed logic function (whether on scope or on controller object)

Filters:
 - should be tested for expected object
 - should be tested for lack of expected object (undefined, null, etc. preferably using angular's presence functions)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167253

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167323

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167326

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167333

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167334

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167337

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167338

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167738

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/169906

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167338
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=88d0226dc68a1ebfbdccc990cf40519608230182
Submitter: Jenkins
Branch: master

commit 88d0226dc68a1ebfbdccc990cf40519608230182
Author: Matt Borland <email address hidden>
Date: Tue Mar 24 11:38:44 2015 -0600

    [Launch Instance Fix] Add Keypair Step Unit Tests

    This patch adds unit tests for the keypair step. These tests are focused
    around the controller and its related components (no selenium tests or view
    tests).

    Change-Id: Ie5f71d550d5beacbe239ee47d2a5531224b43370
    Partial-Bug: 1435869

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/170554

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/169906
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=1f8377d9eb4b8987782060a254538172145013f7
Submitter: Jenkins
Branch: master

commit 1f8377d9eb4b8987782060a254538172145013f7
Author: Matt Borland <email address hidden>
Date: Wed Apr 1 14:06:44 2015 -0600

    [Launch Instance Fix] Add better coverage for widgets

    Adding test coverage for widgets.

    Change-Id: Iea5c4ff90b970dde73006c5bb162c4c4c8529844
    Partial-Bug: 1435869

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167253
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=23134c637a87b11112e73d8e0f3555aab5caa123
Submitter: Jenkins
Branch: master

commit 23134c637a87b11112e73d8e0f3555aab5caa123
Author: Matt Borland <email address hidden>
Date: Tue Mar 24 08:34:14 2015 -0600

    [Launch Instance Fix] Add Network Step Unit Tests

    This patch adds unit tests for the network steps. These tests are focused
    around the controller and its related components (no selenium tests or view
    tests).

    Change-Id: I0f4b0ef900e5f17c7b39e9f3ca60780e0d26b8e8
    Partial-Bug: 1435869

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/172057

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167323
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=4aa435a69b4fe8cb04e4ff75e39989e57beef95b
Submitter: Jenkins
Branch: master

commit 4aa435a69b4fe8cb04e4ff75e39989e57beef95b
Author: Matt Borland <email address hidden>
Date: Tue Mar 24 11:00:17 2015 -0600

    [Launch Instance Fix] Add Configuration Step Unit Tests

    This patch adds unit tests for the configuration step. These tests are focused
    around the controller and its related components (no selenium tests or view
    tests).

    Co-Authored-By: Brian Tully <email address hidden>
    Co-Authored-By: Shaoquan Chen <email address hidden>
    Change-Id: Ic25a36ca598459cce4a577da0a99175fbcd1d27a
    Partial-Bug: 1435869

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167337
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=550d3a821bc8f4cd23f3a50cfa42bf19bd29f0f2
Submitter: Jenkins
Branch: master

commit 550d3a821bc8f4cd23f3a50cfa42bf19bd29f0f2
Author: Matt Borland <email address hidden>
Date: Tue Mar 24 11:34:06 2015 -0600

    [Launch Instance Fix] Add Security Group Step Unit Tests

    This patch adds unit tests for the security group step. These tests are
    focused around the controller and its related components (no selenium tests
    or view tests).

    Change-Id: I14dbc603e3bafdcebcb13b0ef7f77d05a26a2122
    Partial-Bug: 1435869

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/176361

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/178227

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/178434

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/179168

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/179251

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167334
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b0d9a1356dfc0f6995b0a6b31473ff4addf1a60d
Submitter: Jenkins
Branch: master

commit b0d9a1356dfc0f6995b0a6b31473ff4addf1a60d
Author: Matt Borland <email address hidden>
Date: Tue Mar 24 11:26:27 2015 -0600

    [Launch Instance Fix] Add Source Step Unit Tests

    This patch adds unit tests for the source step. These tests are focused
    around the controller and its related components (no selenium tests or view
    tests).

    Co-Authored-By: Kelly Domico <email address hidden>
    Co-Authored-By: Brian Tully <email address hidden>

    Change-Id: Ia31f043cf6f33808a9616388600f2a6810b82b07
    Partial-Bug: 1435869

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matt Borland (<email address hidden>) on branch: master
Review: https://review.openstack.org/167333
Reason: I don't believe the notion of a Details page is being supported now.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matt Borland (<email address hidden>) on branch: master
Review: https://review.openstack.org/176361
Reason: This doesn't serve utility at this point as it was more an experimental patch.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/179168
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2c936706e9411cc28385928af56dcd027ce2e989
Submitter: Jenkins
Branch: master

commit 2c936706e9411cc28385928af56dcd027ce2e989
Author: woodm1979 <email address hidden>
Date: Thu Apr 30 11:12:50 2015 -0600

    Provide unittests for magic-search.js

    Currently, the magic-search.js overrides file does not have any unit
    tests. That's a bad thing.

    Also updated magic-search.js to use $window service rather
    than global window object.

    Co-Authored-By: Kelly Domico <email address hidden>
    Co-Authored-By: Matt Borland <email address hidden>

    Change-Id: I672800acafdd6b5fa28d42deaf4e236bb6ca1aae
    Partial-Bug: 1435869

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/170554
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=1360c94dc67daa71d84717bd6e60bd60d8fa039e
Submitter: Jenkins
Branch: master

commit 1360c94dc67daa71d84717bd6e60bd60d8fa039e
Author: Matt Borland <email address hidden>
Date: Fri Apr 3 10:06:51 2015 -0600

    Extending test coverage for core components

    'Second-layer' pass at extending coverage for core Angular components.
    These are components that have > 50% coverage but can be improved.

    Change-Id: I2302a419042f0475158c22570bfc1c7082bb981d
    Partial-Bug: 1435869

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/176532
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e196aba04ef293d23f8512bc155f539527052a2c
Submitter: Jenkins
Branch: master

commit e196aba04ef293d23f8512bc155f539527052a2c
Author: woodm1979 <email address hidden>
Date: Wed Apr 22 16:54:02 2015 -0600

    Improving filter and existing API service tests

    This patch, combined with other patches, helps improve code coverage in
    the Selenium unit tests.

    Co-Authored-By: Matt Borland <email address hidden>

    Change-Id: I9363bc8bcfcca025a5edcc055c069c262e7cc8d5
    Partial-Bug: 1435869

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/178227
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=64347bb15bf9c8c6959c8fde382abfc1f964ebe5
Submitter: Jenkins
Branch: master

commit 64347bb15bf9c8c6959c8fde382abfc1f964ebe5
Author: Matt Borland <email address hidden>
Date: Tue Apr 28 08:58:02 2015 -0600

    Angular API Unit Tests

    Contains tests for API services. There are currently few of these, so
    these are meant to establish a good baseline. Since many services are
    cookie-cutter, the tests often establish a similar structured pattern.

    Change-Id: Ice0dd49e61b0c828b502ec7632534732f934ae76
    Partial-Bug: 1435869
    Closes-Bug: 1449648

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/179251
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d67a731dffdd89b5f4c3a42c7bf2c9843b3e57a9
Submitter: Jenkins
Branch: master

commit d67a731dffdd89b5f4c3a42c7bf2c9843b3e57a9
Author: woodm1979 <email address hidden>
Date: Thu Apr 30 15:21:29 2015 -0600

    Improve unittests for angular charts

    Currently our angular charts unit tests are a bit incomplete.

    charts.js and chart-tooltip.js don't have any unittests at all.
    pie-chart.js has about 2/3rds coverage and 50% branch coverage.

    Change-Id: Ibf3667b0d4d0707df7b092053c43bcd70d07bc25
    Partial-Bug: 1435869

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167738
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=90f3ce19b5eb0132b809d4f261e45b670feac8c2
Submitter: Jenkins
Branch: master

commit 90f3ce19b5eb0132b809d4f261e45b670feac8c2
Author: Matt Borland <email address hidden>
Date: Wed Mar 25 13:01:21 2015 -0600

    [Launch Instance Fix] Add Model Unit Tests

    This patch adds unit tests for the launch instance model.

    Co-Authored-By: Kelly Domico <email address hidden>

    Change-Id: I6be77ac2fca4c8dc08a0bb21514cdceae7e67bf3
    Partial-Bug: 1435869

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/188967

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167326
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=339d30040b0ce59eb2ea8b024dee4a9bf282a878
Submitter: Jenkins
Branch: master

commit 339d30040b0ce59eb2ea8b024dee4a9bf282a878
Author: Matt Borland <email address hidden>
Date: Tue Mar 24 11:08:43 2015 -0600

    [Launch Instance Fix] Add Flavor Step Unit Tests

    - flavor.js code coverage up to 80%

    This patch adds unit tests for the flavor step. These tests are focused
    around the controller and its related components (no selenium tests or view
    tests).

    Co-Authored-By: Mike Hagedorn <email address hidden>

    Change-Id: Ia9cca258eacc36ac279cf6d21ffa2197f58d9294
    Partial-Bug: 1435869

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/172057
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=9e3af3f992c2bc18a19b1d11a3183a5bd6ac2f82
Submitter: Jenkins
Branch: master

commit 9e3af3f992c2bc18a19b1d11a3183a5bd6ac2f82
Author: Matt Borland <email address hidden>
Date: Thu Apr 9 07:49:44 2015 -0600

    [Launch Instance Fix] Tests for Base Controllers

    Adds tests for the Launch Instance wizard and modal controllers.

    Co-Authored-By: Shaoquan Chen <email address hidden>
    Co-Authored-By: Kelly Domico <email address hidden>

    Change-Id: Iac5a1929a08931c1b74ce94d493ed223158cc030
    Partial-Bug: 1435869

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/188967
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=347a5e3baf53c17837b29f95c7a16a28bde10a0e
Submitter: Jenkins
Branch: master

commit 347a5e3baf53c17837b29f95c7a16a28bde10a0e
Author: Travis Tripp <email address hidden>
Date: Fri Jun 5 02:53:42 2015 -0600

    [Launch Instance Fix] Add Model Block Device Test

    The tests are missing the block device mapping format test.
    This adds it.

    Change-Id: Ifc9810eae8b35299ccbd83924c6f5b1606faf2f7
    Partial-Bug: 1435869

[Travis Tripp (travis-tripp)]

All Baseline Unit Tests are in.

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/178434
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.