Autocomplete on login form doesn't work from until user click outside the form in Firefox

Bug #1433110 reported by Paul Karikh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Sam Betts

Bug Description

How to reproduce:
1) Delete saved logins/passwords pairs for Horizon
2) Login with login form, chose 'save password'
3) Logout
4) Go to the login page. User name and password fields will be empty
5) Try to type your login in login field - there is no autosuggest
6) Click outside the login form
7) Click inside the username field ans start to type uour username - now autosuggestion works like a charm

I've got this issue only in Firefox 36 - there is no such problem with Chrome/Chromium.

Paul Karikh (pkarikh)
description: updated
description: updated
Timur Sufiev (tsufiev-x)
Changed in horizon:
status: New → Confirmed
importance: Undecided → Low
status: Confirmed → Triaged
Sam Betts (sambetts)
Changed in horizon:
assignee: nobody → Sam Betts (sambetts)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/166876

Changed in horizon:
status: Triaged → In Progress
Revision history for this message
Doug Fish (drfish) wrote :

I am able to recreate this behavior on windows on FF31, Chrome 41, and IE11. This is a security problem. I think it must be fixed to have a viable release candidate. Raising the importance + setting Milestone.

Changed in horizon:
importance: Low → High
milestone: none → kilo-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/166876
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e5d5e64fb3b989c4226860fe238866031de172d9
Submitter: Jenkins
Branch: master

commit e5d5e64fb3b989c4226860fe238866031de172d9
Author: Sam Betts <email address hidden>
Date: Mon Mar 23 14:52:57 2015 +0000

    Fix horizon login autocomplete control issues

    The autocomplete html attribute isn't respected by many of the newer
    browsers, so setting autocomplete=False or off will not work to disable
    autocompletion in many cases. https://review.openstack.org/#/c/114312/
    solved this issue for most forms, however the login screen overrides
    these fixes, so this patch ports those changes to the login screen
    fixing the problem of autocomplete not disabling the fields.

    Change-Id: Ibd62b0956991aa3e65e2756fa6750eb9721c3549
    Closes-Bug: 1433110

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.