[Launch Instance Fix] Focus should be trapped in modal dialog box when popping up

Bug #1432810 reported by Shaoquan Chen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Confirmed
Low
Unassigned

Bug Description

When a modal dialog showing up, by design, user cannot click
on buttons and links under the overlay layer. However when
pressing [tab]/[shift + tab] key, user still be able to navigate
the focus to any focusable elements in the page outside the
modal dialog, and interact on it via keyboard, this is not
desired. `focusTrap` service provides an elegant solution for
it.

Changed in horizon:
assignee: nobody → Shaoquan Chen (sean-chen2)
status: New → In Progress
Changed in horizon:
assignee: Shaoquan Chen (sean-chen2) → Richard Jones (r1chardj0n3s)
Changed in horizon:
assignee: Richard Jones (r1chardj0n3s) → Shaoquan Chen (sean-chen2)
summary: - Focus should be trapped in modal dialog box when popping up
+ [Launch Instance Fix] Focus should be trapped in modal dialog box when
+ popping up
Tyr Johanson (tyr-6)
tags: added: ng-subteam-nodefault
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Shaoquan Chen (<email address hidden>) on branch: master
Review: https://review.openstack.org/157656
Reason: This feature work very well and can be a very nice ux enhancement to horizon, but it seems to be be really low priority to the cores. It has been waiting for approval many months and maintaining it become a pain.

Changed in horizon:
assignee: Shaoquan Chen (sean-chen2) → nobody
Revision history for this message
Shaoquan Chen (sean-chen2) wrote :

This is really a low priority to the community and seems to not fit the plan very well. Won't fix.

Changed in horizon:
status: In Progress → New
importance: Undecided → Low
Changed in horizon:
status: New → Confirmed
tags: added: low-hanging-fruit
Ching Kuo (genekuo)
Changed in horizon:
assignee: nobody → Ching Kuo (gene-kuo)
Changed in horizon:
assignee: Ching Kuo (gene-kuo) → bananaapple (bananaapple)
Ching Kuo (genekuo)
Changed in horizon:
assignee: bananaapple (bananaapple) → Ching Kuo (gene-kuo)
assignee: Ching Kuo (gene-kuo) → nobody
Changed in horizon:
assignee: nobody → Sayali Lunkad (sayalilunkad)
Changed in horizon:
assignee: Sayali Lunkad (sayalilunkad) → Annapoornima Koppad (annakoppad)
Changed in horizon:
assignee: Annapoornima Koppad (annakoppad) → nobody
Revision history for this message
Trygve Vea (trygve-vea-gmail) wrote :

This looks fixed.

Opening the dialogue starts out with focus on the X in the top right corner - tab/shift-tab'bing will only cycle through elements in the modal.

Tested on Ocata and devstack with Google Chrome.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.