remove try except from tests

Bug #1425001 reported by Matthias Runge
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Invalid
Undecided
Unassigned

Bug Description

https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/projects/tests.py#L1569

There is a try catch. The caught exception is from keystoneclient, not from horizon itself.

Imho we should remove it.

Besides, this particular test fails, when updating to django-1.7

Matthias Runge (mrunge)
Changed in horizon:
importance: Undecided → Medium
milestone: none → kilo-3
Yash Bathia (ybathia)
Changed in horizon:
assignee: nobody → Yash Bathia (ybathia)
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-3 → kilo-rc1
David Lyle (david-lyle)
Changed in horizon:
milestone: kilo-rc1 → liberty-1
Changed in horizon:
milestone: liberty-1 → liberty-2
Changed in horizon:
milestone: liberty-2 → liberty-3
Revision history for this message
Yash Bathia (ybathia) wrote :

Matthias Runge: Since the code has moved, can you confirm if you are referring to try except present here https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/projects/tests.py#L1498

Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-3 → liberty-rc1
David Lyle (david-lyle)
Changed in horizon:
milestone: liberty-rc1 → next
Ivan Kolodyazhny (e0ne)
Changed in horizon:
status: New → Confirmed
Revision history for this message
Akihiro Motoki (amotoki) wrote :

As of Stein development cycle, such try/except is no longer used.
Marking this as Invalid.

Changed in horizon:
milestone: next → none
assignee: Yash Bathia (ybathia) → nobody
status: Confirmed → Invalid
importance: Medium → Undecided
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.