Subnet Network Address is missing asterisk

Bug #1420370 reported by Rob Cresswell on 2015-02-10
26
This bug affects 4 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Low
Akihiro Motoki

Bug Description

The Network Address field in the Create Subnet workflow (Subnet tab) is missing an asterisk.

Steps to reproduce:

1. Go to Admin -> Networks
2. Click on a Network
3. Click Create Subnet
4. Attempt to create the subnet without filling in the Network Address field.

The error message is at the top of the form, when it should be by the field, and the Network Address field itself is missing an asterisk.

Changed in horizon:
assignee: nobody → Wu Wenxiang (wu-wenxiang)
Rob Cresswell (robcresswell) wrote :

If you get chance, please confirm the bug as well when you assign it to yourself.

Wu Wenxiang (wu-wenxiang) wrote :

Couldn't repro in master.
Could repro in juno.

Changed in horizon:
status: New → Incomplete
Rob Cresswell (robcresswell) wrote :

I've got it here on current master. Create Subnet -> Network Address field has no asterisk but is a required field.

Changed in horizon:
status: Incomplete → New
description: updated
Wu Wenxiang (wu-wenxiang) wrote :

See attachment, it's my screen, I could see the asterisk.
Could you show your screen?

Changed in horizon:
status: New → Incomplete
Rob Cresswell (robcresswell) wrote :

Here's what I see, on chrome/ubuntu

Sam Betts (sambetts) wrote :

That is the wrong modal, you are showing the Create Network modal not the Create Subnet modal.

Changed in horizon:
status: Incomplete → Confirmed
Bradley Jones (bradjones) wrote :

Can confirm for the create 'subnet' modal that the network address has no *

Rob Cresswell (robcresswell) wrote :

Thanks for the confirmation Sam.

@Wu Wenxiang, please follow the steps to reproduce to see the issue.

Fix proposed to branch: master
Review: https://review.openstack.org/158214

Changed in horizon:
status: Confirmed → In Progress

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/158214
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Changed in horizon:
importance: Undecided → High
Changed in horizon:
status: In Progress → Confirmed
Changed in horizon:
assignee: Wu Wenxiang (wu-wenxiang) → nobody
tags: added: low-hanging-fruit
Omar Rivera (gomarivera) on 2016-01-26
Changed in horizon:
assignee: nobody → Omar Rivera (gomarivera)
Omar Rivera (gomarivera) on 2016-01-29
Changed in horizon:
status: Confirmed → In Progress
Rob Cresswell (robcresswell) wrote :

In Progress is set automatically by Infra. If the Infra bot fails for some reason, please link a patch as well.

Changed in horizon:
status: In Progress → Confirmed
Alexis Rivera (gardlt) on 2016-01-29
Changed in horizon:
assignee: Omar Rivera (gomarivera) → German Rivera (gerrivera)

Fix proposed to branch: master
Review: https://review.openstack.org/274222

Changed in horizon:
status: Confirmed → In Progress
Khayam Gondal (khayam-gondal) wrote :

Alexis are you still working on this bug ?

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/274222
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

surekha (surekha23) wrote :

Can I work on this bug.

surekha (surekha23) on 2016-09-12
Changed in horizon:
assignee: Alexis Rivera (gerrivera) → surekha (surekha23)
Changed in horizon:
assignee: surekha (surekha23) → srividyaketharaju (srividya)

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/369477
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Changed in horizon:
assignee: srividyaketharaju (srividya) → nobody
Lucas H. Xu (xuh-2) wrote :

Hey Rob,

Cannot reproduce this and I think we should close this since the current version of Horizon would not have this bug.

Changed in horizon:
status: In Progress → Incomplete
Milan Potdar (milan.potdar) wrote :

It does affect current version of horizon.
To reproduce for master:

click admin-> Networks.
Click on any of network name in the table.
Go to subnet tab.
Click create subnet.

This is where the Subnet Network Address is missing asterisk.

Changed in horizon:
assignee: nobody → Milan Potdar (milan.potdar)
Changed in horizon:
status: Incomplete → Confirmed
Rajib Hossen (rajib.hossen) wrote :

I want to work on this bug.

Changed in horizon:
assignee: Milan Potdar (milan.potdar) → Rajib Hossen (rajib.hossen)
Changed in horizon:
status: Confirmed → In Progress
Andrew Lenards (lenards) wrote :

I have confirmed locally that the commit made in Change-Id 457194 does make the field required.

Andrew Lenards (lenards) wrote :

Also, the validation is present (as desired) for a resolution of this bug.?field.comment=Also, the validation is present (as desired) for a resolution of this bug.?field.comment=Also, the validation is present (as desired) for a resolution of this bug.

Fix proposed to branch: master
Review: https://review.openstack.org/468675

Changed in horizon:
assignee: Rajib Hossen (rajib.hossen) → Andrew Lenards (lenards)

Change abandoned by Andrew Lenards (<email address hidden>) on branch: master
Review: https://review.openstack.org/468675
Reason: Abandoned this as I have achieved what I was hoping for with https://review.openstack.org/457194 now

Andrew Lenards (lenards) wrote :

I believe the patch is a fix, but there are 4 gates failing.

Fix proposed to branch: master
Review: https://review.openstack.org/491609

Changed in horizon:
assignee: Andrew Lenards (lenards) → Lucas H. Xu (xuh-2)
Akihiro Motoki (amotoki) wrote :

I am not sure why low-hanging-fruit bug has HIhg priority.... It looks like Low or Medium.

Changed in horizon:
importance: High → Low

Fix proposed to branch: master
Review: https://review.openstack.org/555096

Changed in horizon:
assignee: Lucas H. Xu (xuh-2) → Akihiro Motoki (amotoki)

Reviewed: https://review.openstack.org/555096
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f8196331ea139f52b303eb87d0280152f06d9475
Submitter: Zuul
Branch: master

commit f8196331ea139f52b303eb87d0280152f06d9475
Author: Akihiro Motoki <email address hidden>
Date: Thu Mar 22 08:32:00 2018 +0900

    Add asterisk to conditionally required fields

    https://review.openstack.org/#/c/552247/ introduced a way to
    add asterisk mark to conditionally required fields.

    This commit covers several known forms:
    - Create Network / Create Subnet
    - Create Port
    - Attach Interface to Instance
    - Add Security Group Rule

    Change-Id: I809c23fd64dc2f379c3fdb585741c6b266ec5b1b
    Closes-Bug: #1420370
    Closes-Bug: #1292165
    Closes-Bug: #1755131

Changed in horizon:
status: In Progress → Fix Released

Change abandoned by Akihiro Motoki (<email address hidden>) on branch: master
Review: https://review.openstack.org/457194
Reason: abandoned due to inactivity. In addition, this bug has been fixed in a different approach.

Change abandoned by Akihiro Motoki (<email address hidden>) on branch: master
Review: https://review.openstack.org/491609
Reason: This is superseded by https://review.openstack.org/555096

This issue was fixed in the openstack/horizon 14.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers