Add page title mixin to all views that can use it

Bug #1413749 reported by Sam Betts
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Sam Betts

Bug Description

This patch adds a mixin for page titles and uses it to replace views that set the page title in the context data:
https://review.openstack.org/#/c/142802

Many other views have titles defined in their templates leading to a lot of duplicated code which could be reduced by using the page title mixin.

Sam Betts (sambetts)
Changed in horizon:
assignee: nobody → Sam Betts (sambetts)
Changed in horizon:
status: New → In Progress
Revision history for this message
Sam Betts (sambetts) wrote :

Not sure if patch set was picked up, this is the link to the review, https://review.openstack.org/#/c/149960/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Sam Betts (<email address hidden>) on branch: master
Review: https://review.openstack.org/149960
Reason: Splitting this patch into much smaller parts.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/154500

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154501

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154503

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154509

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154511

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154517

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154520

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154577

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154579

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154584

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154585

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154588

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154591

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154592

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154595

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154597

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154599

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/154602

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/154503
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0b93ec500eeff0c64e8f4748c0d951445a18f98b
Submitter: Jenkins
Branch: master

commit 0b93ec500eeff0c64e8f4748c0d951445a18f98b
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 13:10:49 2015 +0000

    Reduce page title duplication in Admin Flavors

    Patch https://review.openstack.org/#/c/142802/15 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the admin flavors view.

    Change-Id: I2a75ec719b4e126775cd763caeee0266b87944a5
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154501
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b58f14d5e11745aee2c193011bc6a008ee437b39
Submitter: Jenkins
Branch: master

commit b58f14d5e11745aee2c193011bc6a008ee437b39
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 13:06:03 2015 +0000

    Reduce page title duplication in Admin Defaults

    Patch https://review.openstack.org/#/c/142802/15 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the admin defaults view.

    Change-Id: I7d3523018de6f5a73b583790eecdb386d16e69de
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154599
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8d5c92c01dfb5157764a79576cde33fa82ba775d
Submitter: Jenkins
Branch: master

commit 8d5c92c01dfb5157764a79576cde33fa82ba775d
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 14:19:50 2015 +0000

    Reduce page title duplication in Nexus1000v views

    Patch https://review.openstack.org/#/c/142802 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the project router nexus 1000v views.

    Change-Id: I65561fa557211446ae7c48f5ae72882bcd931e23
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154500
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8e956f7064581cf1818c9673e6ba826d23835666
Submitter: Jenkins
Branch: master

commit 8e956f7064581cf1818c9673e6ba826d23835666
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 12:58:36 2015 +0000

    Reduce page title duplication in Admin Aggregates

    Patch https://review.openstack.org/#/c/142802/15 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the admin aggregates view.

    Change-Id: I48a91c15de1dbeb71ed05a8c95159aea60c5104c
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154584
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f1241546c81484e83bdb2ab0ae4d07c7f7e17826
Submitter: Jenkins
Branch: master

commit f1241546c81484e83bdb2ab0ae4d07c7f7e17826
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 13:37:29 2015 +0000

    Reduce page title duplication in Containers

    Patch https://review.openstack.org/#/c/142802 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the project containers views.

    Change-Id: Id33b338b4496e4bee2ac2b049117d64995e630d7
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154574
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=68e59e1f7d68cb97dc837140014b59d49eaf3e1b
Submitter: Jenkins
Branch: master

commit 68e59e1f7d68cb97dc837140014b59d49eaf3e1b
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 13:32:49 2015 +0000

    Reduce page title duplication in Admin volumes

    Patch https://review.openstack.org/#/c/142802 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the admin volumes views.

    Change-Id: I19f76941a4364261b4d8a067f246919e1ba237de
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154597
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=4e9c0c480f32d6fb6dc9c8fbd75ce3ca1df769a1
Submitter: Jenkins
Branch: master

commit 4e9c0c480f32d6fb6dc9c8fbd75ce3ca1df769a1
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 14:18:13 2015 +0000

    Reduce page title duplication in Stacks

    Patch https://review.openstack.org/#/c/142802 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the project stacks views.

    Change-Id: Icff6df155983adeedec59d3aacdd4a0b685cf9a3
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154592
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6997ddc6ee1008ab01204eac0c04f43cf4d3490a
Submitter: Jenkins
Branch: master

commit 6997ddc6ee1008ab01204eac0c04f43cf4d3490a
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 14:13:14 2015 +0000

    Reduce page title duplication in Images & Instance

    Patch https://review.openstack.org/#/c/142802 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the project images, instances, and overview views.

    Change-Id: I53b4ea3d20add1e5a5ba830535b81ae96bf0e554
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154517
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=73ad5ec1862418adcde86e3623c4997d8db6e862
Submitter: Jenkins
Branch: master

commit 73ad5ec1862418adcde86e3623c4997d8db6e862
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 13:26:56 2015 +0000

    Reduce page title duplication in Admin views

    Patch https://review.openstack.org/#/c/142802 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the admin info, instances, metering and metadata_defs views.

    Change-Id: Ia30fee5318391283cb471a32547e75b1ecfb6de6
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154577
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7365c0c88ec5fb4d10b493b749384ccd37db22f6
Submitter: Jenkins
Branch: master

commit 7365c0c88ec5fb4d10b493b749384ccd37db22f6
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 13:33:56 2015 +0000

    Reduce page title duplication in Identity views

    Patch https://review.openstack.org/#/c/142802 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the identity views.

    Change-Id: I2f240a8b6a0ac76078a930bdf760e1cbab21e0cc
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154511
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a88c80143b4d0e220c5c4b00e1571fd5819435d7
Submitter: Jenkins
Branch: master

commit a88c80143b4d0e220c5c4b00e1571fd5819435d7
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 13:22:10 2015 +0000

    Reduce page title duplication in Admin Images

    Patch https://review.openstack.org/#/c/142802 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the admin images views.

    Change-Id: I53941fadee5338b20ee9c958edc9105757b42b0d
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154595
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=3d71d4bead17cda00b97d0ba26d2379db082c290
Submitter: Jenkins
Branch: master

commit 3d71d4bead17cda00b97d0ba26d2379db082c290
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 14:16:05 2015 +0000

    Reduce title duplication in project networking

    Patch https://review.openstack.org/#/c/142802 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the project network topology, networks and routers views.

    Change-Id: I2a1372eb9d82acb3d9a259e19a3ecfb8aeff4c02
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154602
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=49f844024aa9375e02cabf1fe693d8240ab89098
Submitter: Jenkins
Branch: master

commit 49f844024aa9375e02cabf1fe693d8240ab89098
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 14:25:08 2015 +0000

    Reduce page title duplication in settings and test

    Patch https://review.openstack.org/#/c/142802 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the project settings and the test panel views.

    Change-Id: I4af59bb3c051dcd24e46aacd91c49b8fcc6c10c7
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154509
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c5a6c38512aaf4e373a09c1f0afdb400550b17ee
Submitter: Jenkins
Branch: master

commit c5a6c38512aaf4e373a09c1f0afdb400550b17ee
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 13:18:43 2015 +0000

    Reduce page title duplication in Admin Hypervisors

    Patch https://review.openstack.org/#/c/142802/15 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the admin hypervisors views.

    Change-Id: I848c90b685859bf0822722cfc9dcbe7ce7624479
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154588
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a1ffe755ee255707a4307dde05807c79b7ef91e8
Submitter: Jenkins
Branch: master

commit a1ffe755ee255707a4307dde05807c79b7ef91e8
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 13:41:24 2015 +0000

    Reduce page title duplication in databases

    Patch https://review.openstack.org/#/c/142802 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the project databases and database backups views.

    Change-Id: I06f512f0bea34c5f70106a9f3c13a0279fcd2aac
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154579
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b57a5db1469fca6e4b751cbb97e4f9a318d755f9
Submitter: Jenkins
Branch: master

commit b57a5db1469fca6e4b751cbb97e4f9a318d755f9
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 13:35:27 2015 +0000

    Reduce page title duplication in A and S views

    Patch https://review.openstack.org/#/c/142802 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the project access and security views.

    Change-Id: I58f22a522bcd88b6905a5886427cc3fd7b1915f9
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154591
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=db27b5942e55cc6d745411306c7b56aa1eee4e7f
Submitter: Jenkins
Branch: master

commit db27b5942e55cc6d745411306c7b56aa1eee4e7f
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 13:45:00 2015 +0000

    Reduce page title duplication in Adv net services

    Patch https://review.openstack.org/#/c/142802 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the project firewalls, loadbalancers and vpn views.

    Change-Id: I7e342df51eca075da76d80eb9b5722654edad1e4
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154520
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6fdd220d67d002af4ccd5d0603cb75c42ac2e1c3
Submitter: Jenkins
Branch: master

commit 6fdd220d67d002af4ccd5d0603cb75c42ac2e1c3
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 13:31:13 2015 +0000

    Reduce page title duplication in Admin networking

    Patch https://review.openstack.org/#/c/142802 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the admin networks and routers views.

    Change-Id: Ie725775d8ac9279f9abe21e3afa47854064b6512
    Partial-Bug: 1413749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/154585
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=1e4c7d846293b656a4dc2b761df8685851bd6c88
Submitter: Jenkins
Branch: master

commit 1e4c7d846293b656a4dc2b761df8685851bd6c88
Author: Sam Betts <email address hidden>
Date: Tue Feb 10 13:38:44 2015 +0000

    Reduce page title duplication in Data Processing

    Patch https://review.openstack.org/#/c/142802 adds a method of
    reducing duplication of page title logic, this patch applies that change
    to the project data processing views.

    Change-Id: Ie1567e7b9007b50e2b50b6ec0f60d57706e01edf
    Partial-Bug: 1413749

Changed in horizon:
status: In Progress → Fix Released
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.