User name(with a link) inline edit doesn't work in identity > users > user table

Bug #1410832 reported by Lawrance
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Lawrance

Bug Description

We implement user table inline edit and user detail, so the User Name cell will show input element as text while edting inline because the cell data will be escaped while it has url, we should unescaped inhorizon.tables_inline_edit.js while the cell is link, the patch fix it.

Return escaped data while the cell has url:
https://github.com/openstack/horizon/blob/master/horizon/tables/base.py#L744

Changed in horizon:
assignee: nobody → Lawrance (jing)
status: New → In Progress
Revision history for this message
Lawrance (jing) wrote :
summary: - User name(with a link) inline edit doesn't work
+ User name(with a link) inline edit doesn't work in identity > users >
+ user table
Cindy Lu (clu-m)
Changed in horizon:
importance: Undecided → Medium
David Lyle (david-lyle)
Changed in horizon:
milestone: none → kilo-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/147193
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5131a08a1a0c8e8fb6a925edbe10520e00bae58a
Submitter: Jenkins
Branch: master

commit 5131a08a1a0c8e8fb6a925edbe10520e00bae58a
Author: jing.liuqing <jing.liuqing@99cloud.net>
Date: Wed Jan 14 22:52:10 2015 +0800

    Fix cell(User Name) inline edit with a link in user table

    We implement user table inline edit and user detail, so the User Name
    cell will show input element as text while edting inline because the
    cell data will be escaped while the cell has url, the patch fix it.

    Closes-Bug: 1410832
    Change-Id: Ic249259961624cc52f54c53a8cceb9f1a439e9bf

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.