Pie charts are empty when quota is zero

[Rob Cresswell]

When a users quota for any given service is zero, the pie charts showing this remain empty. This is not helpful behaviour, as an empty chart indicates available quota - only the numeric values show that the current quota is filled, making the chart redundant. We should change the charts to be full when a quota is zero, as this gives an earlier visual indication that the user has no available quota.

[Nikunj Aggarwal (nikunj2512)]

Hi Mc,
I am already working on this bug. And it is a good habit to ask the assignee, if You want to work on same bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/146062

[mc (matic-cankar)]

Sorry Nikunj, I haven't seen this mail. I had wrong/different email account
for Gerrit and Launchpad.

It would be good to comment, if the bug will be fixed in a package with
other improvements. In this case I would stay away.
My intentions were only to learn the whole Gerrit process with a "low
hanging fruit bug" (removing this tag would also hide the bug from fresh
developers). My tutor explained to me that if the bug fixing is not in
progress I can fix it (and my work should not make any harm to anybody).

How can I repair the damage?

On Fri, Jan 9, 2015 at 12:24 PM, Nikunj Aggarwal <email address hidden>
wrote:

> Hi Mc,
> I am already working on this bug. And it is a good habit to ask the
> assignee, if You want to work on same bug.
>
> ** Changed in: horizon
> Assignee: mc (matic-cankar) => Nikunj Aggarwal (nikunj2512)
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1407715
>
> Title:
> Pie charts are empty when quota is zero
>
> Status in OpenStack Dashboard (Horizon):
> In Progress
>
> Bug description:
> When a users quota for any given service is zero, the pie charts
> showing this remain empty. This is not helpful behaviour, as an empty
> chart indicates available quota - only the numeric values show that
> the current quota is filled, making the chart redundant. We should
> change the charts to be full when a quota is zero, as this gives an
> earlier visual indication that the user has no available quota.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/horizon/+bug/1407715/+subscriptions
>

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matija Cankar (<email address hidden>) on branch: master
Review: https://review.openstack.org/146062
Reason: The bugfix will be a part of a bigger picture, see comments above.

Sorry for the mess. Maybe it would be good to remove the "low-hanging-fruit" tag from similar assigned and connected bugs.

[Rob Cresswell (robcresswell-deactivatedaccount)]

I'm inclined to disagree on removing the low-hanging-fruit tag. Basing a patch on another is described in the gerrit workflow doc (https://wiki.openstack.org/wiki/Gerrit_Workflow) and is a useful learning experience. The patch itself is easy to explain and test, so Ithink I'll leave the tag.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/149526

[OpenStack Infra (hudson-openstack)]

Change abandoned by Chris Johnson (<email address hidden>) on branch: master
Review: https://review.openstack.org/149526
Reason: This has been superseded by https://review.openstack.org/#/c/119427/16

[Matthias Runge (mrunge)]

IMHO it'd be better to remove pie charts, when quota is zero.

There is no upper boundary, so there is no "full", half full or whatever.

I'd suggest to show raw numbers instead.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/119427
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=087ccfe740b627ca687b5c8727453dedcf2998cd
Submitter: Jenkins
Branch: master

commit 087ccfe740b627ca687b5c8727453dedcf2998cd
Author: Bradley Jones <email address hidden>
Date: Fri Sep 5 18:43:05 2014 +0100

    Updated overview graph when usage exceeds quota

    Change-Id: Iee24a70c77e7565cb04846f872af4f489165aa05
    Closes-bug: 1333483
    Closes-bug: 1407715