All unit test jobs failing due to timezone change (test_timezone_offset_is_displayed)

[Julie Pichon]

2015-01-02 06:09:33.597 | ======================================================================
2015-01-02 06:09:33.597 | FAIL: test_timezone_offset_is_displayed (openstack_dashboard.dashboards.settings.user.tests.UserSettingsTest)
2015-01-02 06:09:33.597 | ----------------------------------------------------------------------
2015-01-02 06:09:33.597 | Traceback (most recent call last):
2015-01-02 06:09:33.598 | File "/home/jenkins/workspace/gate-horizon-python27/openstack_dashboard/dashboards/settings/user/tests.py", line 30, in test_timezone_offset_is_displayed
2015-01-02 06:09:33.598 | self.assertContains(res, "UTC +04:00: Russia (Moscow) Time")
2015-01-02 06:09:33.598 | File "/home/jenkins/workspace/gate-horizon-python27/.tox/py27/local/lib/python2.7/site-packages/django/test/testcases.py", line 351, in assertContains
2015-01-02 06:09:33.598 | msg_prefix + "Couldn't find %s in response" % text_repr)
2015-01-02 06:09:33.598 | AssertionError: False is not true : Couldn't find 'UTC +04:00: Russia (Moscow) Time' in response
2015-01-02 06:09:33.598 | u"False is not true : Couldn't find 'UTC +04:00: Russia (Moscow) Time' in response" = self._formatMessage(u"False is not true : Couldn't find 'UTC +04:00: Russia (Moscow) Time' in response", "%s is not true" % safe_repr(False))
2015-01-02 06:09:33.598 | >> raise self.failureException(u"False is not true : Couldn't find 'UTC +04:00: Russia (Moscow) Time' in response")

Noticed in master and Icehouse jobs, I assume Juno is affected too. The timezone appears to be listed as UTC +03:00 now.

[Yves-Gwenael Bourhis (yves-gwenael-bourhis)]

As per http://en.wikipedia.org/wiki/Moscow_Time:
Moscow's time zone has been set to UTC+3 permanently on 26 October 2014

[Julie Pichon (jpichon)]

We're already checking for a number of different timezone offsets, I suggest simply removing that one (that leaves 3 other tz checks in that test).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/144732

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/144733

[Julie Pichon (jpichon)]

Eep, looks like we submitted the same patch concurrently, I'll abandon mine. Thanks Yves-Gwenael!

[OpenStack Infra (hudson-openstack)]

Change abandoned by Julie Pichon (<email address hidden>) on branch: master
Review: https://review.openstack.org/144733
Reason: https://review.openstack.org/#/c/144732/ was submitted a minute earlier :)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Yves-Gwenael Bourhis (<email address hidden>) on branch: master
Review: https://review.openstack.org/144732
Reason: Race condition with Julie: https://review.openstack.org/#/c/144733/
:-)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/144735

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/144736

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/144732
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=21d0f092169cb93e98f393f4362456feffee3ed1
Submitter: Jenkins
Branch: master

commit 21d0f092169cb93e98f393f4362456feffee3ed1
Author: Yves-Gwenael Bourhis <email address hidden>
Date: Fri Jan 2 11:47:01 2015 +0100

    Removing Moscow's timezone check

    MOSCOW on October 26 has turned its clocks back one hour switching to permanent
    "winter" time and ending the three-year experiment of living on permanent
    "summer time." No seasonal time change is envisaged from now on.

    For safety, we remove this timezone check

    Change-Id: I1614f8f7adb56903816aa5a093d742925dd51ea8
    Closes-Bug: #1407055

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/144736
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=9120a7f0924a949e96bd9c10b57fa951e2915a72
Submitter: Jenkins
Branch: stable/juno

commit 9120a7f0924a949e96bd9c10b57fa951e2915a72
Author: Yves-Gwenael Bourhis <email address hidden>
Date: Fri Jan 2 11:47:01 2015 +0100

    Removing Moscow's timezone check

    MOSCOW on October 26 has turned its clocks back one hour switching to permanent
    "winter" time and ending the three-year experiment of living on permanent
    "summer time." No seasonal time change is envisaged from now on.

    For safety, we remove this timezone check

    Closes-Bug: #1407055
    (cherry picked from commit 21d0f092169cb93e98f393f4362456feffee3ed1)

    Change-Id: I1614f8f7adb56903816aa5a093d742925dd51ea8

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/144735
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0eef0d882fabf47c309b125dc52bb3364c64eab8
Submitter: Jenkins
Branch: stable/icehouse

commit 0eef0d882fabf47c309b125dc52bb3364c64eab8
Author: Yves-Gwenael Bourhis <email address hidden>
Date: Fri Jan 2 11:47:01 2015 +0100

    Removing Moscow's timezone check

    MOSCOW on October 26 has turned its clocks back one hour switching to permanent
    "winter" time and ending the three-year experiment of living on permanent
    "summer time." No seasonal time change is envisaged from now on.

    For safety, we remove this timezone check

    Closes-Bug: #1407055
    (cherry picked from commit 21d0f092169cb93e98f393f4362456feffee3ed1)

    Change-Id: I1614f8f7adb56903816aa5a093d742925dd51ea8

[Kyrylo Romanenko (kromanenko)]

Result is :

$ ./run_tests.sh openstack_dashboard.dashboards.settings.user.tests.py
Checking environment.
Environment is up to date.
nosetests openstack_dashboard.dashboards.settings.user.tests.py --nocapture --nologcapture --cover-package=openstack_dashboard --cover-inclusive --all-modules --exclude-dir=openstack_dashboard/test/integration_tests --verbosity=1
Creating test database for alias 'default'...
..
----------------------------------------------------------------------
Ran 2 tests in 0.740s

OK