horizon should throw proper error msg when failed to display loadbalancer page

[venkat akkina]

Openstack: ICEHOUSE

Description:

UI page for Project ->Network->Load Balancers is not displayed.

Steps:
========>
1. Created a provider offering (type: LoadBalancer, driver: LB)

2. Created a network, and subnet.

3. Created a pool with subnet created above.

4. Deleted the subnet without deleting the pool assoicated.

5. Now the UI page for Project ->Network->Load Balancers is not displayed and thrown standard error page "something went wrong". <<<<<<<<<<<

--->>> Instead of showing "something went wrong", horizon should display meaningful error message for user to understand the issue.

Observed that subnet id is still attached as a part of the pool.

root@os-158:~# neutron lb-pool-list
+--------------------------------------+--------+---------------+-------------+----------+----------------+--------+
| id | name | provider | lb_method |
protocol | admin_state_up | status |
+--------------------------------------+--------+---------------+-------------+----------+----------------+--------+
| e8ff074c-64ae-468c-a2c3-51b0c0306b71 | pool_1 | haproxy_on_vm | ROUND_ROBIN |
HTTP | True | ACTIVE |
+--------------------------------------+--------+---------------+-------------+----------+----------------+--------+
root@os-158:~#
root@os-158:~# neutron lb-pool-show e8ff074c-64ae-468c-a2c3-51b0c0306b71
+------------------------+--------------------------------------+
| Field | Value |
+------------------------+--------------------------------------+
| admin_state_up | True |
| description | |
| health_monitors | |
| health_monitors_status | |
| id | e8ff074c-64ae-468c-a2c3-51b0c0306b71 |
| lb_method | ROUND_ROBIN |
| members | |
| name | pool_1 |
| protocol | HTTP |
| provider | haproxy_on_vm |
| status | ACTIVE |
| status_description | |
| subnet_id | 274c1806-da49-4eef-b573-6f30783e490e |
| tenant_id | 7799606d678e438f98f339fb0553fb10 |
| vip_id | |
+------------------------+--------------------------------------+
root@os-158:~#
root@os-158:~#
root@os-158:~# neutron subnet-show 274c1806-da49-4eef-b573-6f30783e490e
Unable to find subnet with name '274c1806-da49-4eef-b573-6f30783e490e'
root@os-158:~#

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/147790

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/147790
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8c4b0830a87f511687a9ecc568aa707dfdb343d9
Submitter: Jenkins
Branch: master

commit 8c4b0830a87f511687a9ecc568aa707dfdb343d9
Author: liyingjun <email address hidden>
Date: Fri Jan 16 17:19:24 2015 +0800

    Throw a warning message when failed to get pool detail

    When subnet associated to a pool deleted, the pool detail page will
    throw an exception. Fix the problem by showing a warning message
    when failed to get the expand resources for the pool.

    Change-Id: I9f853505db625527de69c8f620b988e6e42a4339
    Closes-bug: #1406879

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/juno
Review: https://review.openstack.org/174392

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Schwarz (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/174392

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/174392
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.