main block of some detail.html has no "row" and "col-sm-12" <div> elements

Bug #1400317 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Akihiro Motoki

Bug Description

Main block of some detail.html has no "row" and "col-sm-12" <div> elements and as a result some page has no left margin. Most detail page has appropriate left margin.

This is pointed out in a comment of https://review.openstack.org/#/c/129449/

For example, dashboards/project/networks/templates/networks/detail.html

{% block main %}
  {% include "project/networks/_detail_overview.html" %}
  <hr>
  <div id="subnets">
    {{ subnets_table.render }}
  </div>
  <div id="ports">
    {{ ports_table.render }}
  </div>
  {% if dhcp_agent_support %}
    <div id="agents">
      {{ agents_table.render }}
    </div>
  {% endif %}
{% endblock %}

In most pages:

{% block main %}
<div class="row">
  <div class="col-sm-12">
  {% include "admin/volumes/snapshots/_detail_overview.html" %}
  </div>
</div>
{% endblock %}

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/140000

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/140000
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d4ca7e80d23649d08b84d97ae0ae7e9b9ec3ca4b
Submitter: Jenkins
Branch: master

commit d4ca7e80d23649d08b84d97ae0ae7e9b9ec3ca4b
Author: Akihiro Motoki <email address hidden>
Date: Mon Dec 8 22:32:01 2014 +0900

    Wrap the main block of detail.html with col-sm-12 class

    In some detail page, the main block was not wrapped with
    col-sm-12 bootstrap class and it leads to inconsistent
    left margin among detail pages.

    Change-Id: Ib2eb71f66dcd000e823da72166d174baf36c2ff9
    Closes-Bug: #1400317

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.