floating_ip_disassociate port_id parameter never used

Bug #1396050 reported by LIU Yulong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
LIU Yulong

Bug Description

Code:

Neutron:

openstack_dashboard/api/neutron.py

    def disassociate(self, floating_ip_id, port_id):
        update_dict = {'port_id': None}
        self.client.update_floatingip(floating_ip_id,
                                      {'floatingip': update_dict})

Nova:

openstack_dashboard/api/nova.py

    def disassociate(self, floating_ip_id, port_id):
        fip = self.client.floating_ips.get(floating_ip_id)
        server = self.client.servers.get(fip.instance_id)
        self.client.servers.remove_floating_ip(server.id, fip.ip)

python-neutronclient usage:
neutron floatingip-disassociate [-h] [--request-format {json,xml}] FLOATINGIP_ID

python-novaclient usage:
nova floating-ip-disassociate <server> <address>

LIU Yulong (dragon889)
Changed in horizon:
assignee: nobody → LIU Yulong (dragon889)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/137023

Changed in horizon:
status: New → In Progress
LIU Yulong (dragon889)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/137023
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ec93149311342ac9f5c427dd6aef3f7f779ff738
Submitter: Jenkins
Branch: master

commit ec93149311342ac9f5c427dd6aef3f7f779ff738
Author: LIU-Yulong <email address hidden>
Date: Tue Nov 25 17:49:05 2014 +0800

    Remove port_id from floating ip disassociate

    Remove the redundant port_id from parameters of FloatingIpManager
    disassociate function and the related.

    Change-Id: I7425d654d9fee51b6b74e1cda888e12100a9cf3d
    Closes-Bug: #1396050

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.