Activity log for bug #1394573

Date Who What changed Old value New value Message
2014-11-20 13:14:17 Doug Fish bug added bug
2014-11-20 14:22:16 Doug Fish horizon: assignee Doug Fish (drfish)
2014-11-20 14:32:47 Doug Fish description We have several panels where the add filter is used to concatenate an object to form a page title. This is problem for translation https://wiki.openstack.org/wiki/I18n/TranslatableStrings#Use_string_formating_variables.2C_never_perform_string_concatenation ./openstack_dashboard/dashboards/admin/volumes/templates/volumes/volumes/detail.html: {% include "horizon/common/_page_header.html" with title=_("Volume Details: ")|add:volume.name|default:_("Volume Details:") %} ./openstack_dashboard/dashboards/project/images/templates/images/images/detail.html: {% include "horizon/common/_page_header.html" with title=_("Image Details: ")|add:image.name|default:_("Image Details:") %} ./openstack_dashboard/dashboards/project/firewalls/templates/firewalls/updatepolicy.html: {% include "horizon/common/_page_header.html" with title=_("Edit Policy ")|add:name %} ./openstack_dashboard/dashboards/project/firewalls/templates/firewalls/updatefirewall.html: {% include "horizon/common/_page_header.html" with title=_("Edit Firewall ")|add:name %} ./openstack_dashboard/dashboards/project/firewalls/templates/firewalls/updaterule.html: {% include "horizon/common/_page_header.html" with title=_("Edit Rule ")|add:name %} ./openstack_dashboard/dashboards/project/stacks/templates/stacks/resource.html: {% include "horizon/common/_page_header.html" with title=_("Resource Detail: ")|add:resource.resource_name %} ./openstack_dashboard/dashboards/project/stacks/templates/stacks/detail.html: {% include "horizon/common/_page_header.html" with title=_("Stack Detail: ")|add:stack.stack_name %} ./openstack_dashboard/dashboards/project/databases/templates/databases/detail.html: {% include "horizon/common/_page_header.html" with title=_("Instance Details: ")|add:instance.name %} ./openstack_dashboard/dashboards/project/instances/templates/instances/detail.html: {% include "horizon/common/_page_header.html" with title=_("Instance Details: ")|add:instance.name %} ./openstack_dashboard/dashboards/project/networks/templates/networks/detail.html: {% include "horizon/common/_page_header.html" with title=_("Network Detail: ")|add:network.name %} ./openstack_dashboard/dashboards/project/database_backups/templates/database_backups/details.html: {% include "horizon/common/_page_header.html" with title=_("Backup Details: ")|add:backup.name %} ./openstack_dashboard/dashboards/project/volumes/templates/volumes/backups/detail.html: {% include "horizon/common/_page_header.html" with title=_("Volume Backup Details: ")|add:backup.name|default:_("Volume Backup Details:") %} ./openstack_dashboard/dashboards/project/volumes/templates/volumes/volumes/detail.html: {% include "horizon/common/_page_header.html" with title=_("Volume Details: ")|add:volume.name|default:_("Volume Details:") %} ./openstack_dashboard/dashboards/project/volumes/templates/volumes/snapshots/detail.html: {% include "horizon/common/_page_header.html" with title=_("Volume Snapshot Details: ")|add:snapshot.name|default:_("Volume Snapshot Details:") %} ./openstack_dashboard/dashboards/project/access_and_security/templates/access_and_security/security_groups/detail.html: {% include "horizon/common/_page_header.html" with title=_("Manage Security Group Rules: ")|add:security_group.name %} ./openstack_dashboard/dashboards/identity/groups/templates/groups/manage.html: {% include "horizon/common/_page_header.html" with title=_("Group Management: ")|add:group.name %} We have several panels where the add filter is used to concatenate an object to form a page title. This is problem for translation https://wiki.openstack.org/wiki/I18n/TranslatableStrings#Use_string_formating_variables.2C_never_perform_string_concatenation There are 16 instances in the code that can be viewed with grep -r title=_ . | grep add:
2014-11-20 16:40:02 Doug Fish tags i18n
2014-11-20 16:48:29 OpenStack Infra horizon: status New In Progress
2014-12-05 23:05:32 OpenStack Infra horizon: status In Progress Fix Committed
2014-12-18 16:28:15 Thierry Carrez horizon: status Fix Committed Fix Released
2014-12-18 16:28:15 Thierry Carrez horizon: milestone kilo-1
2015-04-30 08:25:45 Thierry Carrez horizon: milestone kilo-1 2015.1.0