scss variables overriding mechanism
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
Fix Released
|
Medium
|
Jiri Tomasek |
Bug Description
The horizon.scss now @imports _variables after importing bootstrap, which prevents us to override bootstrap variables there. (see how scss variables overriding work http://
The fix should move _variables import before bootstrap import in horizon.scss and move all variables defined at the beginning of horizon.scss into _variables.scss.
Also, variables in _variables.scss shoudl be organized into 2 groups for clarity:
1. bootstrap overrides - variables that override bootstrap ones
2. custom horizon variables - variables used by horizon that are not defined by bootstrap
IMHO, all variables in _variables.scss should be marked as !default, so they can be overriden in horizon plugins to maintain Horizon's customization ability.
Changed in horizon: | |
assignee: | nobody → Jiri Tomasek (jtomasek) |
status: | New → In Progress |
Changed in horizon: | |
importance: | Undecided → Medium |
Changed in horizon: | |
milestone: | none → kilo-1 |
Changed in horizon: | |
status: | Fix Committed → Fix Released |
Changed in horizon: | |
milestone: | kilo-1 → 2015.1.0 |
Fix proposed to branch: master /review. openstack. org/133667
Review: https:/